Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/intezer-azure-sentinel-integration-playbooks #8890

Closed
wants to merge 1 commit into from
Closed

feat/intezer-azure-sentinel-integration-playbooks #8890

wants to merge 1 commit into from

Conversation

matany90
Copy link

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@matany90 matany90 requested review from a team as code owners August 28, 2023 08:21
@v-atulyadav v-atulyadav added the Playbook Playbook specialty review needed label Aug 28, 2023
@v-prasadboke
Copy link
Contributor

Hello @matany90, Thank you for raising this PR. This PR will be investigated and will update you about the same by 31 August, 2023.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Metadata is missing from playbook. Can you please add playbook metadata in the azuredeploy.json.

You can refer this Playbook for more clarification:- https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ThreatXCloud/Playbooks/ThreatXPlaybooks/ThreatX-BlockIP-URL/azuredeploy.json

Also can you please share LogicApp designer images.
Thank you.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Hope you are doing well. We just wanted to know if there are any updates on the above requested changes.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above forementioned comments.
Thanks.

@v-prasadboke
Copy link
Contributor

Hello, @matany90. We haven't heard from you in a while. I hope everything is okay with you, and please answer to the comments above.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above forementioned comments.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above mentioned comments.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above requests.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above comments

@v-prasadboke
Copy link
Contributor

Hello @matany90, We are waiting for your response.

@v-prasadboke
Copy link
Contributor

Hello @matany90, Please respond to the above comments. Also please agree to the required license.

@v-prasadboke
Copy link
Contributor

Hello @matany90, We are waiting for your response.

@v-prasadboke
Copy link
Contributor

We wanted to check on the status of PR #8890. PR is pending for more than 30 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation.

@v-prasadboke
Copy link
Contributor

Since we have not received a response in the last 7 days, we are closing your PR #8890 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.

If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

@matany90 matany90 deleted the feat/intezer-azure-sentinel-integration-playbooks branch March 4, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playbook Playbook specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants