Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KQL Training Solution to Address Issues #8895

Merged
merged 11 commits into from
Sep 8, 2023

Conversation

malowe101
Copy link
Collaborator

Required items, please complete

Change(s):

  • Updated IntroToKQL workbook to fix ongoing issue that breaks the tool.
  • Updated the details file to update 2.0.0 to 2.0.1
  • Updated maintemplate to contain the new JSON for the IntotoKQL JSON
  • Updated 2.0.0.zip to 2.0.1.zip that contains the new maintemplate file

Reason for Change(s):

  • IntoToKQL workbook had an issue that broke the tool and prevented users from being able to use it.

Testing Completed:

  • Workbook has been deployed from code and it works as expected.

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

@malowe101 malowe101 requested review from a team as code owners August 28, 2023 23:01
@malowe101
Copy link
Collaborator Author

I cannot repackage this solution as Microsoft has removed admin privileges on local machines. I cannot install the required components to repackage the content.

@v-atulyadav v-atulyadav self-assigned this Aug 29, 2023
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 29, 2023
@v-atulyadav
Copy link
Contributor

Hi @malowe101,

Please refer to the guidelines below to repackage the solution with version 3.0.0.

Please package the solution using V3 tool, please go through this readme file on how to use the V3 tool.
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

Add ReleaseNotes file for solution,please refer below link for how to create ReleaseNotes.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Thanks

@v-atulyadav
Copy link
Contributor

Hi @malowe101, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries and/or support. Thanks

@v-atulyadav
Copy link
Contributor

Hi @malowe101,
I would appreciate it if you checked the suggested changes above and acted accordingly. Thanks

@v-atulyadav
Copy link
Contributor

Hi @malowe101,
I've repackaged the solution with v3 and am now trying to clear validations. I'll test the package and let you know by 11 Aug 2023. Thanks

@v-atulyadav v-atulyadav merged commit b62aa77 into Azure:master Sep 8, 2023
29 checks passed
@malowe101
Copy link
Collaborator Author

Sorry, I have been in and out of office. My apologies for the lack of response but thank you for assisting in getting this addressed. Regarding repackaging, the company has locked down local accounts so we cannot run the packaging script if we do not have the correct components for it already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants