Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DoD Zero Trust Strategy Workbook v1.0 (Stand-alone) #8950

Merged
merged 20 commits into from
Sep 18, 2023

Conversation

ChhornGLim
Copy link
Contributor

@ChhornGLim ChhornGLim commented Sep 5, 2023

Change(s):

  • Adding DoD Zero Trust Strategy Workbook v1.0 (Stand-alone)

Reason for Change(s):

  • New Sentinel workbook in support of the latest DoD Zero Trust Strategy

Version Updated:

  • n/a (initial release v1.0 / minor revisions will be x.x and major revisions will be x.0)

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@ChhornGLim ChhornGLim requested review from a team as code owners September 5, 2023 13:57
@ChhornGLim
Copy link
Contributor Author

@ChhornGLim please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@ChhornGLim ChhornGLim closed this Sep 5, 2023
@ChhornGLim ChhornGLim reopened this Sep 5, 2023
@ChhornGLim
Copy link
Contributor Author

@ChhornGLim please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@v-atulyadav v-atulyadav added the Workbook Workbook specialty review needed label Sep 6, 2023
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Sep 6, 2023

Hello @ChhornGLim, Thank you for raising this PR. This PR will be investigated, Also can you please share sample data to test the workbook. And Please change fromtemplateid
"fromTemplateId": "sentinel-UserWorkbook"

@ChhornGLim
Copy link
Contributor Author

Hello @ChhornGLim, Thank you for raising this PR. This PR will be investigated, Also can you please share sample data to test the workbook. And Please change fromtemplateid "fromTemplateId": "sentinel-UserWorkbook"

Done! Thank you, @v-prasadboke !

@v-prasadboke
Copy link
Contributor

Hello @ChhornGLim, Thank you for sharing the sample data. Continue to review this PR and update you about the same before 12 September, 2023.

@ChhornGLim
Copy link
Contributor Author

Hello @ChhornGLim, Thank you for sharing the sample data. Continue to review this PR and update you about the same before 12 September, 2023.

Thank you for the update and assistance, @v-prasadboke!

@v-prasadboke
Copy link
Contributor

Hello @ChhornGLim, Please resolve the validation fails. A link at line 15254 contains a hardcoded link. This link refers to a specific LA workspace which should not be the case.

Also another check is failing for Links containing .us which should be replaced with .com. Thanks

@ChhornGLim
Copy link
Contributor Author

ChhornGLim commented Sep 12, 2023

Hello @ChhornGLim, Please resolve the validation fails. A link at line 15254 contains a hardcoded link. This link refers to a specific LA workspace which should not be the case.

Also another check is failing for Links containing .us which should be replaced with .com. Thanks

@v-prasadboke - Thanks for bringing this to our attention! Links have been fixed and we have (re)validated .us portal links.

@v-prasadboke
Copy link
Contributor

  1. Hello @ChhornGLim, All the documentation links in the workbook should have .com links not .us
    Please replace the [ https://.us ] with [ https://.com ].

  2. Simliar case has been found Same as earlier for hardcoded link mentioned at line 19407 ,

image

@v-prasadboke
Copy link
Contributor

Hello @ChhornGLim, We are still investigating this PR.
We will update you about the same before 19 September 2023.

@ChhornGLim
Copy link
Contributor Author

Hello @ChhornGLim, We are still investigating this PR. We will update you about the same before 19 September 2023.

@v-prasadboke - Removed all "/en-us/" from docs/resource links and cleaned up one remaining subscription-specific link (a196fd3). Thanks!

v-prasadboke
v-prasadboke previously approved these changes Sep 18, 2023
@v-atulyadav v-atulyadav merged commit 493ca96 into Azure:master Sep 18, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workbook Workbook specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants