Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commvault Integration with Microsoft Azure Sentinel - V.1.0 (minor changes) #9016

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

Cv-securityIQ
Copy link
Contributor

Change(s):

Made formatting changes like modified "azure sentinel" to "Microsoft sentinel" and formatted the descriptions.

Reason for Change(s):
Changes required to complete the publishing of the solution from the partner center.

Initial integration PR.
Version Updated:

Yes
Initial pull request.
Testing Completed:

Yes
Checked that the validations are passing and have addressed any issues that are present:

Yes

@Cv-securityIQ Cv-securityIQ requested review from a team as code owners September 15, 2023 09:16
@v-atulyadav v-atulyadav self-assigned this Sep 15, 2023
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Sep 15, 2023
v-atulyadav
v-atulyadav previously approved these changes Sep 15, 2023
@v-atulyadav v-atulyadav dismissed their stale review September 15, 2023 09:42

found issues

@v-atulyadav
Copy link
Contributor

Hi @Cv-securityIQ,
As per certification the solutionid should be commvault.cvsecurityiq, can you please confirm with this. In your maintemplate, we can see the following solutionid.
image
Also there is Azure Sentinel text in playbook's prerequisites and maintemplate.json
image
Thanks

@Cv-securityIQ
Copy link
Contributor Author

Hi @Cv-securityIQ, As per certification the solutionid should be commvault.cvsecurityiq, can you please confirm with this. In your maintemplate, we can see the following solutionid. image Also there is Azure Sentinel text in playbook's prerequisites and maintemplate.json image Thanks

Hi, should I make the changes to the maintemplate.json manually or repackage the solution after changing the text in the playbook pre-requisites?

By the solution id as per certification you mean the offer name that gets mentioned in the Partner Center, right? Also, should the solution id be formed as "publisherId.offerId" that will be used in the partner center?

@v-atulyadav
Copy link
Contributor

v-atulyadav commented Sep 15, 2023

Hi @Cv-securityIQ, As per certification the solutionid should be commvault.cvsecurityiq, can you please confirm with this. In your maintemplate, we can see the following solutionid. image Also there is Azure Sentinel text in playbook's prerequisites and maintemplate.json image Thanks

Hi, should I make the changes to the maintemplate.json manually or repackage the solution after changing the text in the playbook pre-requisites?

By the solution id as per certification you mean the offer name that gets mentioned in the Partner Center, right? Also, should the solution id be formed as "publisherId.offerId" that will be used in the partner center?

Hi @Cv-securityIQ,

  1. Make these changes manually, but make sure you keep the same maintemplate in the zip file.
  2. The offer is mentioned in the partner center and the solution ID should formed as publisherId.offerId

@Cv-securityIQ
Copy link
Contributor Author

commvault

I've made the required changes, the publisher id and offer id have been modified. Since the official documentation says "Ensure that the OfferID contains the keyword "sentinel". Consider using the format: microsoft-sentinel-solution-", we are following this naming convention and we'll create a new publish request with the same as we cannot modify the offer id of the existing publish request.

@v-atulyadav v-atulyadav merged commit 58c7ff2 into Azure:master Sep 15, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants