Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limiting script execution minutes for Auth0 #9075

Merged
merged 14 commits into from
Nov 14, 2023

Conversation

v-sabiraj
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-prasadboke v-prasadboke self-assigned this Sep 22, 2023
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Sep 22, 2023
@v-muuppugund
Copy link
Contributor

Please add respective screen shots for the testing of the code done in description for this changes

Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for all the scenarios executed

@v-mchatla
Copy link
Contributor

v-mchatla commented Nov 6, 2023

Success invocation from customer workspace
image

Removed duplicate logging statements
Fix for CodeQL issue
Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using client credential flow and can't we move to certificate base access token generation?

Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add clear documentation for the code added

Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

@v-mchatla
Copy link
Contributor

v-mchatla commented Nov 10, 2023

We are using client credential flow and can't we move to certificate base access token generation?

Created this backlog item to work on the suggested items. Can you please provide approval for now as we made these changes as part of IcM and need to make it live as soon as possible as its having breaking changes.

@v-mchatla
Copy link
Contributor

Please add respective screen shots for the testing of the code done in description for this changes

Added success screenshot.

@v-mchatla
Copy link
Contributor

We are using client credential flow and can't we move to certificate base access token generation?

Created backlog item to incorporate these changes as we need to push this PR as soon as possible to live as its having breaking changes.

Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with suggestions are added in the below backlog
https://dev.azure.com/SentinelThirdPartyEcosystem/Sentinel%20TCS/_workitems/edit/7968/

@v-dvedak v-dvedak merged commit 336dfee into master Nov 14, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content-Package Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants