-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limiting script execution minutes for Auth0 #9075
limiting script execution minutes for Auth0 #9075
Conversation
Function App Timeout Issue fix
Updated the code to fix None Type Error
Please add respective screen shots for the testing of the code done in description for this changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases for all the scenarios executed
Removed redundant code for statemanager file update
This reverts commit fb8a031.
Updating state manager after pushing the events to sentinel
Added common function to update statmarker file
Removed duplicate logging statements
Fix for CodeQL issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using client credential flow and can't we move to certificate base access token generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add clear documentation for the code added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code
Created this backlog item to work on the suggested items. Can you please provide approval for now as we made these changes as part of IcM and need to make it live as soon as possible as its having breaking changes. |
Added success screenshot. |
Created backlog item to incorporate these changes as we need to push this PR as soon as possible to live as its having breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with suggestions are added in the below backlog
https://dev.azure.com/SentinelThirdPartyEcosystem/Sentinel%20TCS/_workitems/edit/7968/
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.