Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SharePoint_Downloads_byNewIP.yaml #9141

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

praveenthepro
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s): Current query is generating too many FP's, so added additional logics to minimize the FP's

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@praveenthepro praveenthepro requested review from a team as code owners October 3, 2023 11:32
@v-atulyadav v-atulyadav added Solution Solution specialty review needed Analytic Rules labels Oct 3, 2023
petebryan
petebryan previously approved these changes Oct 3, 2023
// Filter for significant deviations
UserBehaviorAnalysis
| where Deviation > threshold
| project StartTimeUtc, EndTimeUtc, UserId, UserType, Operation, ClientIP, tostring(GeoLocation), Site_Url, OfficeObjectId, OfficeWorkload, UserAgent, Deviation, Count=RecentCount
| extend timestamp = StartTimeUtc, AccountCustomEntity = UserId, IPCustomEntity = ClientIP, URLCustomEntity = Site_Url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to have these *CustomEntity columns now - I know this wasn't the focus of your work here but whilst you are updating can you please remove these columns and update the entity mappings to just map to the underlying columns.

@v-atulyadav
Copy link
Contributor

Hi @praveenthepro, please look into below KQL validation error. Thanks

image

@praveenthepro
Copy link
Contributor Author

@v-atulyadav , Fixed the KQL error, Kindly please checkout

@v-atulyadav
Copy link
Contributor

Thanks @praveenthepro.

@petebryan petebryan merged commit 41a237b into Azure:master Oct 6, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants