Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added analytic rule for vulnerability of CVE-2023-4863 #9162

Merged
merged 8 commits into from
Oct 11, 2023

Conversation

kfriede
Copy link
Contributor

@kfriede kfriede commented Oct 5, 2023

Change(s):

  • Added analytic rule to Microsoft 365 solution for CVE-2023-4863

Reason for Change(s):

  • Emerging threat

Version Updated:

  • N/A (v1.0.0)

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@kfriede kfriede requested review from a team as code owners October 5, 2023 18:38
@v-atulyadav
Copy link
Contributor

Hi @kfriede,
Could you please check the analytical rule for the missing properties?. Thanks

  • tactics
  • relevantTechniques
  • version
    Note: Initial version should be 1.0.0

please refer Query-Style-Guide for the same

Also check below sample example for your reference
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Microsoft%20365%20Defender/Analytic%20Rules/AVSpringShell.yaml

@kfriede
Copy link
Contributor Author

kfriede commented Oct 9, 2023

Hi @v-atulyadav, I've updated the file with the requested changes

@v-atulyadav
Copy link
Contributor

Hi @kfriede,
Could you please group the different entity types together into a single entity type instead of having multiple entity types for the same value?. Rest query looks good. Thanks
image

Below is for your reference.
image

@kfriede
Copy link
Contributor Author

kfriede commented Oct 10, 2023

Hi @v-atulyadav, requested change has been made. Didn't know that grouping like that was legal, that's much more concise.

@v-atulyadav
Copy link
Contributor

Hello @kfriede,
I have reverted the above commit because it was causing a validation failure. We will continue to proceed with the earlier approach. Thanks

@v-atulyadav v-atulyadav merged commit ef2d1d4 into Azure:master Oct 11, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants