Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CyberArkEPMSentinelConn.zip #9200

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Update CyberArkEPMSentinelConn.zip #9200

merged 5 commits into from
Nov 23, 2023

Conversation

cyberark-bizdev
Copy link
Contributor

Required items, please complete

Change(s):

  • Repackage distribution of CyberArkEPMSentinelConn.zip as it had wrong structure

Reason for Change(s):

  • The function CyberArkEPM was not being recognized properly

@cyberark-bizdev cyberark-bizdev requested review from a team as code owners October 11, 2023 17:51
@v-atulyadav v-atulyadav self-assigned this Oct 12, 2023
@v-atulyadav v-atulyadav added the Connector Connector specialty review needed label Oct 12, 2023
@cyberark-bizdev
Copy link
Contributor Author

Approved

@v-mchatla
Copy link
Contributor

Hi @cyberark-bizdev
Sorry for the delay. We are getting module not found error while testing the latest zip.
image
Can you please add all the dependencies to the python package folder and confirm.
Thanks

@cyberark-bizdev
Copy link
Contributor Author

Added lxml dependency to requirements.txt

Review

@cyberark-bizdev
Copy link
Contributor Author

Approved

@v-mchatla
Copy link
Contributor

Hi @cyberark-bizdev
Can you please update the zip folder with updated requirement.txt and also add relevant lxml packages under .python_packages folder.
Can you please share the working screenshot from function app, just to ensure the function app is working fine without any errors.
I have tried adding these things locally and tested, but I'm running into below error. So please help me with the success screenshot to approve the changes.
image
Thanks

@cyberark-bizdev
Copy link
Contributor Author

Review

@v-mchatla
Copy link
Contributor

Hi @cyberark-bizdev
I have tried testing the updated zip file, still getting the same issue.
Thanks

@v-mchatla
Copy link
Contributor

v-mchatla commented Nov 7, 2023 •
edited
Loading

Hi @cyberark-bizdev
Can you please verify the function app with latest zip and share the success screenshot. I'm still getting the same import issue shared above.
Thanks

v-mchatla
v-mchatla approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@v-mchatla v-mchatla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I don't see any package related issues now.
image

@v-atulyadav v-atulyadav merged commit d1b4e07 into Azure:master Nov 23, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-mchatla v-mchatla v-mchatla approved these changes

@v-atulyadav v-atulyadav v-atulyadav approved these changes

Assignees

@v-atulyadav v-atulyadav

@v-mchatla v-mchatla

Labels
Connector Connector specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyberark-bizdev @v-mchatla @v-atulyadav