Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink pipeline changes #9254

Closed
wants to merge 27 commits into from
Closed

Hyperlink pipeline changes #9254

wants to merge 27 commits into from

Conversation

v-amolpatil
Copy link
Contributor

@v-amolpatil v-amolpatil commented Oct 22, 2023

Required items, please complete

Change(s):

  • Add support to check hyperlink validation for mainTemplate and CreateUiDefinition files.
  • When there is any change in Data connector azuredeploy file then it should check if "Website_run_from_package" attribute value is having correct hyperlink or not.

Reason for Change(s):

  • Add support to check hyperlink validation for mainTemplate and CreateUiDefinition files.
  • When there is any change in Data connector azuredeploy file then it should check if "Website_run_from_package" attribute value is having correct hyperlink or not.

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Testing result:
When links are invalid in maintemplate:
image

When all changes are good in azuredeploy file in data connector
image

When Website Run from Package property link is invalid:
image

When all links in Data connector azuredeploy file is correct:
image

@v-amolpatil v-amolpatil self-assigned this Oct 22, 2023
@v-amolpatil v-amolpatil marked this pull request as ready for review October 25, 2023 04:26
@v-amolpatil v-amolpatil requested review from a team as code owners October 25, 2023 04:26
@v-amolpatil v-amolpatil marked this pull request as draft October 26, 2023 04:39
@v-amolpatil v-amolpatil marked this pull request as ready for review October 31, 2023 04:12
@v-amolpatil v-amolpatil marked this pull request as draft November 6, 2023 12:21
@v-amolpatil
Copy link
Contributor Author

Closing this as rishikesh is working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant