Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackaged Microsoft Defender 365 to latest version #9259

Closed
wants to merge 2 commits into from

Conversation

kfriede
Copy link
Contributor

@kfriede kfriede commented Oct 23, 2023

Change(s):

  • Update solution to 3.0.1

Reason for Change(s):

  • In PR Added analytic rule for vulnerability of CVE-2023-4863 #9162, I was not aware of the need to run the Solution repackage, or add the file to SolutionMetadata.json. This commit fixes this issue to properly include the file and increment the solution. Solution has clearly not been updated in some time.

Version Updated:

  • Solution version updated from 3.0.0 -> 3.0.1

Testing Completed:

  • Need Help

Checked that the validations are passing and have addressed any issues that are present:

  • During repackaging of solution, multiple issues appeared:

    1. Error occured in catch of createSolutionV3 file Error details are The file MicrosoftDefenderForIdentityWorkbook has metadata with source -> kind = Community | Standalone. Please remove it so that it can be packaged as a solution. -- This was fixed by modifying /Workbooks/WorkbooksMetadata.json (as shown in this PR)
    2. Failed to download /home/kevin/Git/Azure-Sentinel/Solutions/Microsoft 365 Defender/Data Connectors/MicrosoftThreatProtection.json -- Please ensure that it exists in /home/kevin/Git/Azure-Sentinel/Solutions/ -- Unsure how to fix, help required
    3. Several failures for apiVersions Should Be Recent -- Unsure how to fix, help required
    4. Several failures for IDs Should Be Derived From ResourceIDs -- Unsure how to fix, help required

@kfriede kfriede requested review from a team as code owners October 23, 2023 13:56
@v-atulyadav v-atulyadav self-assigned this Oct 25, 2023
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Oct 25, 2023
@v-atulyadav
Copy link
Contributor

Hi @kfriede,
Currently, we are repackaging this solution for a few changes, so we are closing this request. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants