-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the DataConnector code by implementing Durable Function App. #9265
Updated the DataConnector code by implementing Durable Function App. #9265
Conversation
Hi @jayeshprajapaticrest, thanks for raising this PR, we will review this PR by 27 Oct 2023. |
@v-rbajaj Sure, Will wait for response from you regarding the PR review status update. |
Hi @jayeshprajapaticrest, sorry for the delay, will review the PR by 30 Oct 2023. |
Hi @jayeshprajapaticrest, can you please add After that can you please repackage this solution post it? |
@v-rbajaj As this is the updated PR for the already merged solution of RubrikSecurityCloud and this file is already their. We just updated connector related files so it would not be the part of this PR changes. |
@v-rbajaj Any update on this PR? |
Hi @jayeshprajapaticrest, I am reviewing this PR and will be reviewed by today EOD. |
Hi @jayeshprajapaticrest, we are trying to deploy maintemplate to check if the contents are working fine or not. But the "manage" button is missing. We tried deploying other maintemplate and the manage button does appear fine, there is something wrong with the maintemplate. Please give us time to investigate on this issue and we will get back to you by 02 Nov 2023. |
@v-rbajaj |
@@ -15,10 +15,10 @@ | |||
"Playbooks/RubrikRansomwareDiscoveryAndVMRecovery/azuredeploy.json" | |||
], | |||
"Data Connectors": [ | |||
"Data Connectors/RubrikWebhookEvents_API_FunctionApp.json" | |||
"Data Connectors/RubrikDataConnector/Rubrik_FunctionApp.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jayeshprajapaticrest, we can't find this file on the given path. And so we are getting this error while trying to repackage it. Please update the correct path and repackage the solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-rbajaj Updated the PR with the mentioned changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jayeshprajapaticrest, as mentioned earlier, the solution needs to be repackaged too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-rbajaj I have make the folder path as mentioned in the above path and also used the same path in the SolutionMetadata.json file and re-packaged the solution. Please verify and review the PR.
Thanks
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: