Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the DataConnector code by implementing Durable Function App. #9265

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

jayeshprajapaticrest
Copy link
Contributor

Change(s):

  • Updated existing data connector with the Durable Function

Reason for Change(s):

  • Due to the client side timeout error

Version Updated:

  • Updated to 3.1.0

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@jayeshprajapaticrest jayeshprajapaticrest requested review from a team as code owners October 24, 2023 08:12
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Oct 25, 2023
@v-rbajaj
Copy link
Contributor

Hi @jayeshprajapaticrest, thanks for raising this PR, we will review this PR by 27 Oct 2023.

@jayeshprajapaticrest
Copy link
Contributor Author

Hi @jayeshprajapaticrest, thanks for raising this PR, we will review this PR by 27 Oct 2023.

@v-rbajaj Sure, Will wait for response from you regarding the PR review status update.

@v-rbajaj
Copy link
Contributor

Hi @jayeshprajapaticrest, sorry for the delay, will review the PR by 30 Oct 2023.

@v-rbajaj
Copy link
Contributor

Hi @jayeshprajapaticrest, can you please add Solutions\RubrikSecurityCloud\SolutionMetadata.json file here?

After that can you please repackage this solution post it?

@jayeshprajapaticrest
Copy link
Contributor Author

@v-rbajaj As this is the updated PR for the already merged solution of RubrikSecurityCloud and this file is already their. We just updated connector related files so it would not be the part of this PR changes.

@jayeshprajapaticrest
Copy link
Contributor Author

jayeshprajapaticrest commented Nov 1, 2023

@v-rbajaj Any update on this PR?
As this PR is for issue fix for the already available solution and this fix needs to available publicly as early as possible. So I request you to expediate the process to get it merge.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Nov 1, 2023

@v-rbajaj Any update on this PR? As this PR is for issue fix for the already available solution and this fix needs to available publicly as early as possible. So I request you to expediate the process to get it merge.

Hi @jayeshprajapaticrest, I am reviewing this PR and will be reviewed by today EOD.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Nov 1, 2023

Hi @jayeshprajapaticrest, we are trying to deploy maintemplate to check if the contents are working fine or not. But the "manage" button is missing. We tried deploying other maintemplate and the manage button does appear fine, there is something wrong with the maintemplate. Please give us time to investigate on this issue and we will get back to you by 02 Nov 2023.
image

@jayeshprajapaticrest
Copy link
Contributor Author

Hi @jayeshprajapaticrest, we are trying to deploy maintemplate to check if the contents are working fine or not. But the "manage" button is missing. We tried deploying other maintemplate and the manage button does appear fine, there is something wrong with the maintemplate. Please give us time to investigate on this issue and we will get back to you by 02 Nov 2023. image

@v-rbajaj
No problem. Let us know if anything is required from our end.
Thanks!

@@ -15,10 +15,10 @@
"Playbooks/RubrikRansomwareDiscoveryAndVMRecovery/azuredeploy.json"
],
"Data Connectors": [
"Data Connectors/RubrikWebhookEvents_API_FunctionApp.json"
"Data Connectors/RubrikDataConnector/Rubrik_FunctionApp.json"
Copy link
Contributor

@v-rbajaj v-rbajaj Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jayeshprajapaticrest, we can't find this file on the given path. And so we are getting this error while trying to repackage it. Please update the correct path and repackage the solution.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-rbajaj Updated the PR with the mentioned changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jayeshprajapaticrest, as mentioned earlier, the solution needs to be repackaged too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-rbajaj I have make the folder path as mentioned in the above path and also used the same path in the SolutionMetadata.json file and re-packaged the solution. Please verify and review the PR.
Thanks

@v-dvedak v-dvedak merged commit 6dc2dad into Azure:master Nov 7, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants