Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1-update-pr #9309

Merged
Merged

Conversation

nbyt3
Copy link
Contributor

@nbyt3 nbyt3 commented Oct 31, 2023

Required items, please complete

Change(s):

Initial submission for the cyborgsecurity-hunter-solution
Reason for Change(s):
Updating PR #9041

See guidance below
Testing Completed:
Yes

Checked that the validations are passing and have addressed any issues that are present:

@nbyt3 nbyt3 requested review from a team as code owners October 31, 2023 17:18
@nbyt3
Copy link
Contributor Author

nbyt3 commented Oct 31, 2023

@v-rbajaj Here is the new PR. I closed #9041

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Oct 31, 2023
v-rbajaj
v-rbajaj previously approved these changes Nov 1, 2023
Copy link
Contributor

@v-rbajaj v-rbajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@v-rbajaj v-rbajaj dismissed their stale review November 1, 2023 13:20

Create ui needs to be updated

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Nov 1, 2023

Hi @nbyt3, we will suggest the required changes by 3rd Nov 2023.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Nov 3, 2023

Hi @nbyt3, we will suggest the required changes by 3rd Nov 2023.

Hi @nbyt3, sorry for the delay, we will provide the changes by 6 Nov 2023.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Nov 6, 2023

Hi @nbyt3, please push these changes in create ui and the zip.
3.0.0.zip
createUiDefinition.json

v-rbajaj
v-rbajaj previously approved these changes Nov 8, 2023
v-atulyadav
v-atulyadav previously approved these changes Nov 8, 2023
@v-rbajaj v-rbajaj dismissed stale reviews from v-atulyadav and themself November 8, 2023 10:05

Needs changes

@nbyt3
Copy link
Contributor Author

nbyt3 commented Nov 8, 2023

@v-rbajaj Thank you for the feedback. I just updated the branch.

@v-dvedak v-dvedak merged commit 6700446 into Azure:master Nov 10, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants