Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create User Session Impersonation(Okta) #9691

Merged
merged 15 commits into from
Jan 17, 2024
Merged

Conversation

praveenthepro
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@praveenthepro praveenthepro requested review from a team as code owners December 29, 2023 06:12
@v-atulyadav v-atulyadav added Analytic Rules Solution Solution specialty review needed labels Dec 29, 2023
@v-prasadboke
Copy link
Contributor

Hello @praveenthepro, can you please resolve the validation error

@praveenthepro
Copy link
Contributor Author

Hello @praveenthepro, can you please resolve the validation error

@v-prasadboke fixed the errors kindly please check

@v-prasadboke
Copy link
Contributor

Hello @praveenthepro, we are facing trouble while repackaging the solution. We are currently working on this and we will get back to you by 09 January, 2024

@v-prasadboke
Copy link
Contributor

Hello @praveenthepro, Sorry for the delay but Okta single sign on has a new ccp connector which is causing the packaging tool failure.
We are still working on it and update you about the same before 12 January, 2024.

@v-prasadboke
Copy link
Contributor

Hello @praveenthepro, Sorry for the delay but on 12th I was on leave. I'll be checking this PR and update you about the same before EOD 16 January.

@v-prasadboke
Copy link
Contributor

Hello @praveenthepro, We have successfully repackaged the solution and waiting for sample data to ingest in LA. Will update you by 17 January EOD on this.

v-prasadboke
v-prasadboke previously approved these changes Jan 17, 2024
@v-atulyadav v-atulyadav merged commit 2f73623 into Azure:master Jan 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants