Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extractor is not gettting all the products(OpenAPi) with the right APIS #413

Closed
seilorjunior opened this issue Nov 8, 2023 · 3 comments · Fixed by #437
Closed
Labels
bug Something isn't working

Comments

@seilorjunior
Copy link
Contributor

seilorjunior commented Nov 8, 2023

Release version

v4.10.1

Describe the bug

When we run the extractor is needs to get all APIS related to the products.

Expected behavior

As example when we changed a API with a new product(OpenAPi), it needs to remove the API from the latest product.

Actual behavior

When we are using with the current version, it is not removing from the older product and it is letting the API in two products.

Reproduction Steps

  • Create two products(product1 and product2)(OpenAPi)
  • Add an API to the product1.
    image
  • Run the extractor
  • Run the publisher.
  • Use the same API and remove the product1 from this and add the product2 to this API.
    image
  • Run the extractor(it needs to get all products again to validate which API belongs for each product)
  • Run the publisher.
  • We are going to get an error {"code":"ValidationError","message":"One or more fields contain incorrect values:","details":[{"code":"ValidationError","target":"aid","message":"API cannot be added to more than one open products."}]}}'.
Copy link

github-actions bot commented Nov 8, 2023

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

@seilorjunior seilorjunior changed the title [BUG] Extractor is not only gettting the products with the right APIS [BUG] Extractor is not gettting the products with the right APIS Nov 8, 2023
@seilorjunior
Copy link
Contributor Author

seilorjunior commented Nov 8, 2023

@guythetechie @waelkdouh there is any workaround for that?

@seilorjunior seilorjunior changed the title [BUG] Extractor is not gettting the products with the right APIS [BUG] Extractor is not gettting all the products(OpenAPi) with the right APIS Nov 8, 2023
@waelkdouh waelkdouh added the bug Something isn't working label Dec 1, 2023
@seilorjunior
Copy link
Contributor Author

seilorjunior commented Dec 5, 2023

Hello this bug just happened when we are moving a product without any api.

Example: product1 and product2

  1. The api belongs first to product1 in dev
  2. We move the api with product1 to prod.
  3. We change the api to product2 in dev, the product1 must not have any api.
  4. We move he api with product2 to prod.
  5. We are going to have the api with the product1 and product2 in prod.

@waelkdouh @guythetechie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants