Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] I noticed in the example publisher configuration file, the Subscription GUID is suppose to be filled in. #534

Closed
zcarroll4 opened this issue Apr 19, 2024 · 2 comments

Comments

@zcarroll4
Copy link
Contributor

Release version

Most recent version

Question Details

Is storing the Subscription ID in source code a security concern?

image

Expected behavior

N/A

Actual behavior

N/A

Reproduction Steps

N/A

See configuration.prod.yaml for example.

"subscription Guid goes here" in several places throughout the file.

Copy link

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

@waelkdouh
Copy link
Contributor

Feel free to store it as a secret. Just follow the steps demonstrated for the secret entry in the file which uses replace token extension.

@waelkdouh waelkdouh closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants