Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated replacetokens-task from v3 to v6 #676

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

ollief87
Copy link
Contributor

@ollief87 ollief87 commented Oct 1, 2024

@waelkdouh
Copy link
Contributor

@ollief87 this is ready for us to start testing?

@ollief87
Copy link
Contributor Author

@waelkdouh yes it is

@naimadswdn
Copy link

naimadswdn commented Dec 9, 2024

The warnings in the Publisher pipeline were annoying, so I applied the change provided by @ollief87 and it works perfectly fine.
When we can expect the official merge of this fix?

@waelkdouh
Copy link
Contributor

@ollief87 @naimadswdn did you get the chance to test the changes under the github pipeline as well? I noticed that you only update the azure devops version.

@naimadswdn
Copy link

I only tested the Azure DevOps code.
Anyway, when checking the GitHub pipelines, I can see these are using different library for replace tokens: https://github.com/Azure/apiops/blob/main/tools/github_workflows/run-publisher-with-env.yaml#L42C1-L52C68

and with the latest version (v1.3), so I doubt there is anything to update there.

The library used in the ADO pipelines is deprecated, that is why it should be replaced.

@ollief87
Copy link
Contributor Author

@waelkdouh as pointed out by @naimadswdn the GitHub Actions workflow uses a different library cschleiden/replace-tokens and the GitHub Actions workflow is already using the latest version of that library v1.3

@waelkdouh
Copy link
Contributor

Thanks @ollief87 and @naimadswdn for the confirmation. I will go and merge and release a new version shortly.

@waelkdouh waelkdouh merged commit af87700 into Azure:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants