Remove unused SharedKeyLitePolicy and connection string helpers in Ta…

…bles. (#6268) * Remove SharedKeyLitePolicy and connection string helpers in Tables. * Remove files and tests that are no longer necessary.
Azure · Nov 27, 2024 · 4efb0fc · 4efb0fc
1 parent 11ee6a6
commit 4efb0fc
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 308 deletions.
diff --git a/sdk/tables/azure-data-tables/CMakeLists.txt b/sdk/tables/azure-data-tables/CMakeLists.txt
@@ -57,16 +57,13 @@ set(
 set(
   AZURE_DATA_TABLES_SOURCE
     src/account_sas_builder.cpp
-    src/credentials/named_key_credential.cpp
     src/cryptography/hmacsha256.cpp
     src/models.cpp
-    src/policies/shared_key_lite_policy.cpp
     src/policies/tenant_bearer_token_policy.cpp
     src/policies/timeout_policy.cpp
     src/private/hmacsha256.hpp
     src/private/package_version.hpp
     src/private/policies/service_version_policy.hpp
-    src/private/policies/shared_key_lite_policy.hpp
     src/private/policies/tenant_bearer_token_policy.hpp
     src/private/policies/timeout_policy.hpp
     src/private/serializers.hpp

diff --git a/sdk/tables/azure-data-tables/inc/azure/data/tables/credentials/named_key_credential.hpp b/sdk/tables/azure-data-tables/inc/azure/data/tables/credentials/named_key_credential.hpp
@@ -8,9 +8,6 @@
 #include <memory>
 #include <mutex>
 #include <string>
-namespace Azure { namespace Data { namespace Tables { namespace _detail { namespace Policies {
-  class SharedKeyLitePolicy;
-}}}}} // namespace Azure::Data::Tables::_detail::Policies
 
 namespace Azure { namespace Data { namespace Tables { namespace Sas {
   class AccountSasBuilder;
@@ -28,7 +25,7 @@ namespace Azure { namespace Data { namespace Tables { namespace Credentials {
     /**
      * @brief Initializes a new instance of the NamedKeyCredential.
      *
-     * @param accountName Name of the  account.
+     * @param accountName Name of the account.
      * @param accountKey Access key of the
      * account.
      */
@@ -38,10 +35,10 @@ namespace Azure { namespace Data { namespace Tables { namespace Credentials {
     }
 
     /**
-     * @brief Update the  account's access key. This intended to be used when you've
+     * @brief Update the account's access key. This intended to be used when you've
      * regenerated your account's access keys and want to update long lived clients.
      *
-     * @param accountKey An  account access key.
+     * @param accountKey An account access key.
      */
     void Update(std::string accountKey)
     {
@@ -55,7 +52,6 @@ namespace Azure { namespace Data { namespace Tables { namespace Credentials {
     const std::string AccountName;
 
   private:
-    friend class Azure::Data::Tables::_detail::Policies::SharedKeyLitePolicy;
     friend class Azure::Data::Tables::Sas::AccountSasBuilder;
     friend class Azure::Data::Tables::Sas::TablesSasBuilder;
 
@@ -69,17 +65,4 @@ namespace Azure { namespace Data { namespace Tables { namespace Credentials {
     std::string m_accountKey;
   };
 
-  namespace _detail {
-    struct ConnectionStringParts
-    {
-      std::string AccountName;
-      std::string AccountKey;
-      Azure::Core::Url TableServiceUrl;
-      std::shared_ptr<NamedKeyCredential> KeyCredential;
-    };
-
-    ConnectionStringParts ParseConnectionString(const std::string& connectionString);
-    std::string GetDefaultScopeForAudience(const std::string& audience);
-  } // namespace _detail
-
 }}}} // namespace Azure::Data::Tables::Credentials
diff --git a/sdk/tables/azure-data-tables/src/credentials/named_key_credential.cpp b/sdk/tables/azure-data-tables/src/credentials/named_key_credential.cpp
diff --git a/sdk/tables/azure-data-tables/src/policies/shared_key_lite_policy.cpp b/sdk/tables/azure-data-tables/src/policies/shared_key_lite_policy.cpp
diff --git a/sdk/tables/azure-data-tables/src/private/policies/shared_key_lite_policy.hpp b/sdk/tables/azure-data-tables/src/private/policies/shared_key_lite_policy.hpp
diff --git a/sdk/tables/azure-data-tables/src/table_clients.cpp b/sdk/tables/azure-data-tables/src/table_clients.cpp
@@ -5,7 +5,6 @@
 #include "azure/data/tables/table_service_client.hpp"
 #include "private/package_version.hpp"
 #include "private/policies/service_version_policy.hpp"
-#include "private/policies/shared_key_lite_policy.hpp"
 #include "private/policies/tenant_bearer_token_policy.hpp"
 #include "private/policies/timeout_policy.hpp"
 #include "private/serializers.hpp"
@@ -17,7 +16,6 @@
 using namespace Azure::Data::Tables;
 using namespace Azure::Data::Tables::_detail::Policies;
 using namespace Azure::Data::Tables::_detail::Xml;
-using namespace Azure::Data::Tables::Credentials::_detail;
 using namespace Azure::Data::Tables::_detail;
 
 TableServiceClient::TableServiceClient(

diff --git a/sdk/tables/azure-data-tables/test/ut/CMakeLists.txt b/sdk/tables/azure-data-tables/test/ut/CMakeLists.txt
@@ -22,7 +22,6 @@ add_executable (
     sas_test.cpp
     serializers_test.hpp
     serializers_test.cpp
-    shared_key_lite_policy_test.cpp
     table_client_test.cpp
     table_client_test.hpp
     transactions_test.hpp

diff --git a/sdk/tables/azure-data-tables/test/ut/shared_key_lite_policy_test.cpp b/sdk/tables/azure-data-tables/test/ut/shared_key_lite_policy_test.cpp