Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm-machinelearning Workspace get is missing managedNetwork attribute #30587

Closed
1 of 6 tasks
Abdelmoneim-Nafea opened this issue Jul 31, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@Abdelmoneim-Nafea
Copy link

Abdelmoneim-Nafea commented Jul 31, 2024

  • Package Name: arm-machinelearning
  • Package Version: 2.2.0
  • Operating system: MacOS Sonoma 14.5
  • nodejs
    • version: 18.19.0
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
The Workspace listBySubscription as well as the get is missing the attribute managedNetwork even though it is the Workspace schema.

I have done some digging into the node SDK and found that the attribute properties.managedNetwork exists in the raw response but gets excluded in the mapper.

I understand that this managedNetwork is a new attribute which doesn't get returned in the API version "2022-10-01". I have tried the latest API version ""2024-04-01" with no success. I have tried different packages including an alpha package with no success either.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy an ML workspace in azure
  2. Run this command in Azure terminal and notice it comes back with the response
az ml workspace show
  --name workspace-name
  --resource-group resource-group-name
  --query '{"managedNetwork":managed_network}'
  1. Run the client.workspaces.get(resourceGroupName, name) in node after updating the client with the latest api version apiVersion: "2024-04-01" and notice the attribute managedNetwork is missing

Expected behavior
The listBySubscription as well as the get response should include the managedNetwork attribute

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels Jul 31, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github.

@kazrael2119
Copy link
Contributor

will check

@kazrael2119
Copy link
Contributor

kazrael2119 commented Aug 1, 2024

@Abdelmoneim-Nafea
SDK is generated from swagger, and the package 2.2.0 uses api version 2022-10-01 which doesn't support managedNetwork model in the list result, so in our sdk, it is not generated too. That's why you use 2024-04-01 but it still missing

@kazrael2119
Copy link
Contributor

Add Service Attention label for service team awareness

and
cc @josefree for awareness

@Abdelmoneim-Nafea
Copy link
Author

Abdelmoneim-Nafea commented Aug 1, 2024

Thanks @kazrael2119 for having a look at it. It looks like when using the api version "2024-04-01", the managedNetwork gets returned in the raw response but excluded when serialised. Is it possible to add in the managedNetwork into the "Workspace" mapper? I believe this will fix the problem

@kazrael2119
Copy link
Contributor

kazrael2119 commented Aug 2, 2024

Thanks @kazrael2119 for having a look at it. It looks like when using the api version "2024-04-01", the managedNetwork gets returned in the raw response but excluded when serialised. Is it possible to add in the managedNetwork into the "Workspace" mapper? I believe this will fix the problem

@Abdelmoneim-Nafea, I tried to use the 2024-04-01 to generate the package
azure-arm-machinelearning-3.0.0.zip

could you try to use this and call that operation again?
Notice: this package's client name is changed from AzureMachineLearningWorkspaces to AzureMachineLearningServicesManagementClient

@Abdelmoneim-Nafea
Copy link
Author

Thanks @kazrael2119, I can confirm this package works as expected. I can see the managedNetwork in the response 🥳

Will you be publishing this package anytime soon ?

@Abdelmoneim-Nafea
Copy link
Author

Hi @kazrael2119, is their any plan to publish this new v3 package ?

@kazrael2119
Copy link
Contributor

there's a release request https://github.com/Azure/sdk-release-request/issues/5422 here

@kazrael2119
Copy link
Contributor

new package released here : https://www.npmjs.com/package/@azure/arm-machinelearning/v/3.0.0

@kazrael2119 kazrael2119 added needs-author-feedback Workflow: More information is needed from author to address the issue. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Aug 23, 2024
Copy link

Hi @Abdelmoneim-Nafea. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@Abdelmoneim-Nafea
Copy link
Author

Abdelmoneim-Nafea commented Aug 29, 2024

Thanks a lot @kazrael2119, I confirm the new package works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants