Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Guide - azure-storage to storage-file-share for azure.createFileService #30614

Open
andrei-dascalu opened this issue Aug 1, 2024 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@andrei-dascalu
Copy link

Is your feature request related to a problem? Please describe.
The migration guide (to help migration from the old js azure-storage package to `@azure/storage-file-share) found at https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/storage/storage-file-share/MigrationGuide.md only describes how to update client creation when using connection strings. I'm using

azure.createFileService(
      storageAccountName,
      storageAccountKey,
    );

to create the file service and I'm unable to find a relevant equivalent way of creating a file share service instance. The closest I found actually refers to accessing a file endpoint.

Describe the solution you'd like
Update documentation to cover this use case in the upgrade path.

Describe alternatives you've considered
I've been searching the codebase (TS declarations) to find an alternative

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@xirzec
Copy link
Member

xirzec commented Aug 6, 2024

@andrei-dascalu is this what you are looking for?

@xirzec xirzec added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Aug 6, 2024
@github-actions github-actions bot removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Hi @andrei-dascalu. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@andrei-dascalu
Copy link
Author

@xirzec thanks! I looks like it. It seems that the old client had some wrapper to abstract the need to create the domain based on storageAccountName. Would be nice if the docs would mention this case.

@github-actions github-actions bot added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. labels Aug 7, 2024
@xirzec xirzec added the Docs label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants