Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadocs on dialog based AcquireTokens could be improved #1267

Open
danieldobalian opened this issue Jul 20, 2018 · 1 comment
Open

Javadocs on dialog based AcquireTokens could be improved #1267

danieldobalian opened this issue Jul 20, 2018 · 1 comment
Assignees
@shoatman @hamiltonha
Labels
Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue

Comments

@danieldobalian
Copy link
Contributor

The javadocs for the two dialog-based acquiretoken overloads are not very intuitive, do not express limitations of broker interaction in these scenarios, and do not describe the functional behavior of the method.
@danieldobalian danieldobalian mentioned this issue Jul 20, 2018
Merged
@danieldobalian danieldobalian self-assigned this Jul 20, 2018
@danieldobalian
Copy link
Contributor Author

Addressed in #1268

@iambmelt iambmelt added Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue and removed Enhancement labels Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoatman shoatman

@hamiltonha hamiltonha

Labels
Enhancement This is a feature request to add functionality that is not currently supported Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iambmelt @danieldobalian @shoatman @hamiltonha