Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthenticationSettings.getBrokerPackageName() returns wrong value #1483

Open
daniel-robertson opened this issue Dec 3, 2019 · 1 comment
Open

AuthenticationSettings.getBrokerPackageName() returns wrong value #1483

daniel-robertson opened this issue Dec 3, 2019 · 1 comment
Assignees
@shahzaibj
Labels
Bug - P2 A problem that needs to be fixed for a feature to function as intended Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue

Comments

@daniel-robertson
Copy link

Expected behavior
AuthenticationSettings.INSTANCE.getBrokerPackageName() should return the package name of the app which ADAL is using as a broker.

Actual behavior
AuthenticationSettings.INSTANCE.getBrokerPackageName() always returns com.microsoft.windowsintune.companyportal, even if no broker app is installed.

Reproducible on ADAL 1.16.3
@daniel-robertson daniel-robertson changed the title AuthenticationSettings.getBrokerPackageName returns wrong value AuthenticationSettings.getBrokerPackageName() returns wrong value Dec 3, 2019
@hamiltonha hamiltonha added the bug label Dec 9, 2019
@iambmelt iambmelt added Bug - P2 A problem that needs to be fixed for a feature to function as intended Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue and removed bug labels Dec 19, 2019
@iambmelt
Copy link
Member

This likely cannot change for back-compat reasons; current implementation appears to be a few years old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzaibj shahzaibj

Labels
Bug - P2 A problem that needs to be fixed for a feature to function as intended Internal Issue created by a project contributor Issue Triage The engineering team has looked into the issue, understood the issue, labelled/classified the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daniel-robertson @iambmelt @shahzaibj @hamiltonha