-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing MsalModule which does not have a ɵmod property #6051
Comments
Hey @Venators! Can you share your app.module.ts code where you are setting up the NgModule? |
Hi @lalimasharda,
|
Good to rule out the app.module.ts file! I looked at those older issues prior to logging my issue but didn't think there was a solution there as I believe I'm already using the standard build?
|
@Venators Can I confirm what version of Angular and RxJS you are using? |
Hi @jo-arroyo, |
@Venators Unfortunately, this may be related to Ivy incompatibility with our v2 library. Our alpha version for MSAL Angular has been released, could you please try upgrading to Angular 15 and trying it with our latest alpha version of MSAL Angular? |
@Venators This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale. |
I've branched my app and upgraded Angular to v15, and upgraded @azure/msal-angular & @azure/msal-browser to 3.0.0-alpha.2, and I can confirm that the tests pass. I'm assuming the alpha packages are not production suitable and that the mix of Angular 15 and the alpha packages working means there'll be no fix for an Angular 14/v2 package mix? Is there a timeline on when the packages will move out of alpha? |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @jo-arroyo please follow up. |
3 similar comments
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @jo-arroyo please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @jo-arroyo please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @jo-arroyo please follow up. |
@Venators Yes, you're correct - the v2 package will not be updated to support Ivy. The v3 package is now in beta, we have not yet committed to a timeline to move out of beta but you can track #5410 for updates on that. Closing as it sounds like this is now understood/resolved, let us know if you have further questions. Thanks! |
Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.37.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.5.7
Public or Confidential Client?
Public
Description
Hello 👋🏻
I've recently upgraded from Angular 12 to 13, which broke the Jest test for AppComponent, with the errors centring on MSAL. I updated @azure/msal-angular and @azure/msal-browser to their latest v2 packages, but this made no difference. I looked up the angular13-rxjs7-sample-app and aligned my app.component.spec.ts with that of the sample app - this helped to solve the initial error I was facing (NG0204: Can't resolve all parameters for MsalService: (?, ?).) but has thrown (Importing MsalModule which does not have a ɵmod property) instead, and this error I can't shake.
Importing MsalModule which does not have a ɵmod property
Has anyone encountered this, and/or could shed some light on how I resolve this?
MSAL Configuration
Relevant Code Snippets
Identity Provider
Azure B2C Basic Policy
Source
External (Customer)
The text was updated successfully, but these errors were encountered: