Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagedIdentityTokenResponse's expires_in is not calculated correctly #7098

Closed
2 tasks
Robbie-Microsoft opened this issue May 14, 2024 · 0 comments · Fixed by #7070
Closed
2 tasks

ManagedIdentityTokenResponse's expires_in is not calculated correctly #7098

Robbie-Microsoft opened this issue May 14, 2024 · 0 comments · Fixed by #7070
Assignees
@Robbie-Microsoft
Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p1 P1 and P2 are priorities of the bug. P1 bugs should get Fixed/Closed within 4 weeks.

Comments

@Robbie-Microsoft
Copy link
Collaborator

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

2.7.0

Wrapper Library

Not Applicable

Wrapper Library Version

None

Public or Confidential Client?

Confidential

Description

ManagedIdentityTokenResponse's expires_in is not calculated correctly. It does not match the .NET implementation.

The Azure Identity SDK team noticed that expires_in was incorrectly calculated while adopting msal-node's Managed Identity implementation.

Error Message

No response

MSAL Logs

No response

Network Trace (Preferrably Fiddler)

  • Sent
  • Pending

MSAL Configuration

N/A

Relevant Code Snippets

N/A

Reproduction Steps

N/A

Expected Behavior

N/A

Identity Provider

Entra ID (formerly Azure AD) / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

No response

Source

Internal (Microsoft)
@Robbie-Microsoft Robbie-Microsoft added question Customer is asking for a clarification, use case or information. bug-unconfirmed A reported bug that needs to be investigated and confirmed labels May 14, 2024
@Robbie-Microsoft Robbie-Microsoft self-assigned this May 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 14, 2024
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package labels May 14, 2024
@Robbie-Microsoft Robbie-Microsoft added bug A problem that needs to be fixed for the feature to function as intended. p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months. and removed question Customer is asking for a clarification, use case or information. bug-unconfirmed A reported bug that needs to be investigated and confirmed Needs: Attention 👋 Awaiting response from the MSAL.js team labels May 14, 2024
@Robbie-Microsoft Robbie-Microsoft linked a pull request May 14, 2024 that will close this issue
Managed Identity: ManagedIdentityTokenResponse's expires_in is now calculated correctly #7070
Merged
@Robbie-Microsoft Robbie-Microsoft added p1 P1 and P2 are priorities of the bug. P1 bugs should get Fixed/Closed within 4 weeks. and removed p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robbie-Microsoft Robbie-Microsoft

Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p1 P1 and P2 are priorities of the bug. P1 bugs should get Fixed/Closed within 4 weeks.
Projects
None yet
Milestone
No milestone
1 participant
@Robbie-Microsoft