Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 Standalone MSAL Angular v3 Sample Doesnt work and Documentation is wrong #7106

Closed
Pr1ke opened this issue May 16, 2024 · 1 comment · Fixed by #7108
Closed

Angular 17 Standalone MSAL Angular v3 Sample Doesnt work and Documentation is wrong #7106

Pr1ke opened this issue May 16, 2024 · 1 comment · Fixed by #7108
Assignees
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@Pr1ke
Copy link

Pr1ke commented May 16, 2024

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Documentation Location

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/samples/msal-angular-v3-samples/angular17-standalone-sample/README.md

Description

The Sample references a package "e2e-test-utils" which doesnt exist and fails to install, the readme states "Open ./src/main.ts in an editor.
Replace client id with the Application (client) ID from the portal registration, or use the currently configured lab registration."

the Main.ts File does not offer a space to insert the client id.

I tried changing the client id found inside the environment.ts files (all of them) but the website still uses a different client id which doesnt belong to me.

@Pr1ke Pr1ke added documentation Related to documentation. question Customer is asking for a clarification, use case or information. labels May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 16, 2024
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels May 16, 2024
@konstantin-msft konstantin-msft linked a pull request May 16, 2024 that will close this issue
@konstantin-msft
Copy link
Collaborator

konstantin-msft commented May 16, 2024

Hi @Pr1ke. Thanks for bringing it up. I will update README.md shortly.

  1. Please use ./src/app/app.config.ts to set the client id and other params.
  2. Please remove e2e-test-utils from package.json for local development.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels May 16, 2024
@konstantin-msft konstantin-msft self-assigned this May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Awaiting response from issue author label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants