Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate ManagedIdentitySourceName #7181

Closed
2 tasks
maorleger opened this issue Jun 27, 2024 · 1 comment
Closed
2 tasks

Duplicate ManagedIdentitySourceName #7181

maorleger opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package question Customer is asking for a clarification, use case or information.

Comments

@maorleger
Copy link

maorleger commented Jun 27, 2024

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

2.9.2

Wrapper Library

Not Applicable

Wrapper Library Version

None

Public or Confidential Client?

Confidential

Description

ManagedIdentitySourceNames defines both Imds and DefaultToImds but only one of these is actually used in getManagedIdentitySource

We should remove one of the two, probably Imds, from the public API

Alternatively, you could update the getManagedIdentitySources type to:

public getManagedIdentitySource(): Exclude<ManagedIdentitySourceNames, "Imds">

So developers writing code against this know which value to check against when they want to do something special for IMDS flows (like probing the IMDS endpoint) instead of always remembering to check both values (or looking into the implementation to see that only one is actually used)

playground example

Error Message

No response

MSAL Logs

No response

Network Trace (Preferrably Fiddler)

  • Sent
  • Pending

MSAL Configuration

{}

Relevant Code Snippets

N/A

Reproduction Steps

N/A

Expected Behavior

N/A

Identity Provider

Entra ID (formerly Azure AD) / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

No response

Source

Internal (Microsoft)

@maorleger maorleger added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Jun 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jun 27, 2024
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package labels Jun 27, 2024
@Robbie-Microsoft Robbie-Microsoft self-assigned this Jun 27, 2024
@Robbie-Microsoft
Copy link
Collaborator

Not fixing, per offline discussion

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

2 participants