-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to fix iso-8859-2 Encoding warning? #345
Comments
Ran into same issue recently. Is there any plan to fix this? Thanks |
I had the same issue, but was able to fix it for myself adding BOM to my CSPROJ files. |
By the way it also seems to be an easy fix to add a "supress file encoding warnings" flag, and change the following part: vsts-assemblyinfo-task/src/netframework/index.ts Lines 229 to 240 in 6369290
as such: function setFileEncoding(file: string, model: models.NetFramework) {
const encoding = getFileEncoding(file);
logger.debug(`Detected file encoding: ${encoding}`);
model.detectedFileEncoding = model.fileEncoding;
if (model.fileEncoding === 'auto') {
model.detectedFileEncoding = encoding;
} else if (model.fileEncoding !== encoding && !model.supressFileEncodingWarnings) { // <-- CHANGE HERE
logger.warning(`Detected file encoding (${encoding}) is different to the one specified (${model.fileEncoding}).`);
}
} I'm happy to make a PR for this if required, however I think adding the BOM to the files should be sufficient. |
##[warning]Detected file encoding (iso-8859-2) is different to the one specified (utf-8).
Hi,
my .csproj file ist utf-8 and task is also with utf-8 encoding:
Everything works fine incl. copyright symbol ©.
I just want to remove warning message.
Thanks!
The text was updated successfully, but these errors were encountered: