Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle commented entries in AssemblyInfo #365

Open
dbenzhuser opened this issue Mar 6, 2024 · 0 comments
Open

Handle commented entries in AssemblyInfo #365

dbenzhuser opened this issue Mar 6, 2024 · 0 comments

Comments

@dbenzhuser
Copy link

In a project my AssmblyInfo.cs files contained commented version entries like this:

// Version information for the assembly is set in CI.
////[assembly: AssemblyVersion("0.0.0.0")]
////[assembly: AssemblyFileVersion("0.0.0.0")]

But even though the task output showed that the files had been processed successfully, the resulting assemblies still had their version set to 0.0.0.0.

Turns out the task just replaced the values, not recognizing that the entries were disabled:

// Version information for the assembly is set in CI.
////[assembly: AssemblyVersion("1.2.3.4")]
////[assembly: AssemblyFileVersion("1.2.3.0")]`

Small fix on my side of course, but tricky to realize what went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant