Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelling queued tasks should likely not splice/mutate the array #177

Closed
stefanpenner opened this issue Oct 30, 2016 · 3 comments
Closed

cancelling queued tasks should likely not splice/mutate the array #177

stefanpenner opened this issue Oct 30, 2016 · 3 comments

Comments

@stefanpenner
Copy link
Collaborator

stefanpenner commented Oct 30, 2016 •
edited
Loading

Rather then costly array splicing, we should just mark the particular task as "cancelled" and then skip it in the flush.

relevant code: https://github.com/ebryn/backburner.js/blob/master/lib/backburner/queue.js#L190-L217
@stefanpenner stefanpenner changed the title cancelling queued tasks should likely not mutating the array cancelling queued tasks should likely not splice/mutate the array Oct 30, 2016
@stefanpenner stefanpenner mentioned this issue Oct 30, 2016
Merged
@rwjblue
Copy link
Collaborator

rwjblue commented Oct 30, 2016

Sounds like a good idea to me, I'll try to poke at it today...

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 30, 2016

Submitted #178 to get a baseline before messing with things...

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 21, 2018

replaced by #226

@rwjblue rwjblue closed this as completed Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @rwjblue