New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uniswap references #9

Open

GalloDaSballo opened this issue Nov 1, 2021 · 0 comments

Collaborator

GalloDaSballo commented Nov 1, 2021

badger-strategy-mix-v1/deps/BaseStrategy.sol

Line 45 in c97eda8

address public constant uniswap =

Remove uniswap address and the code used for swapping, as well as the approveHelper

Rationale:
Nobody uses it, we always write our own swap code, just remove it to avoid enforcing a style and overhead that is not actually used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment