Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The whole class does not get parsed if END METHOD. is used at the end of a constructor #223

Closed
gustason opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
blocked by 🌳 Blocked by tree-sitter implementation bug Something isn't working

Comments

@gustason
Copy link
Collaborator

For example,

CLASS DecoratedMotorcycle: 

    CONSTRUCTOR DecoratedMotorcycle():
        message "moto".
    END METHOD.

END CLASS.

image

@gustason gustason added bug Something isn't working to create 🌳 Create and link tree-sitter ticket labels Sep 25, 2024
@eglekaz
Copy link
Collaborator

eglekaz commented Oct 11, 2024

END METHOD should not be used to end constructor. It should be END [CONSTRUCTOR]
Documentation: https://documentation.progress.com/output/ua/OpenEdge_latest/pdsoe/PLUGINS_ROOT/com.openedge.pdt.langref.help/rfi1424920513810.html

@gustason please check and close the issue if everything is okay.

@eglekaz eglekaz removed the to create 🌳 Create and link tree-sitter ticket label Oct 11, 2024
@gustason
Copy link
Collaborator Author

gustason commented Dec 11, 2024

Even though this is not written in the documentation, it does compile. It should not be used, however, it is possible to use it anyway. Therefore, it should be parsed by tree-sitter.

@eglekaz
Copy link
Collaborator

eglekaz commented Dec 12, 2024

Registered: usagi-coffee/tree-sitter-abl#106

@eglekaz eglekaz assigned eglekaz and unassigned gustason Dec 12, 2024
@eglekaz eglekaz added the blocked by 🌳 Blocked by tree-sitter implementation label Dec 12, 2024
@eglekaz eglekaz mentioned this issue Jan 10, 2025
@eglekaz
Copy link
Collaborator

eglekaz commented Jan 10, 2025

Fixed with: #290

@eglekaz eglekaz closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by 🌳 Blocked by tree-sitter implementation bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants