Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help for one key don't working #31

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

razzeee
Copy link
Contributor

@razzeee razzeee commented Sep 8, 2024

I had success with this on my board and tbh, seeing the bodge wire being recommended that fast, kinda made me panic.

@burkfers
Copy link
Collaborator

burkfers commented Sep 8, 2024

Recommending less drastic action first is good, I agree.

nb: Even if you do need a bodge wire, there's no need to panic. There's plenty of bodges in the wild and the boards are no less beautiful :)

@razzeee
Copy link
Contributor Author

razzeee commented Sep 9, 2024

I guess, still it's not that appealing to have to do a bodge, when you just got a new board that should work fine :)

@bstiq
Copy link
Member

bstiq commented Sep 9, 2024

Made it more verbose, thoughts?

@bstiq bstiq requested a review from burkfers September 9, 2024 09:10
Copy link
Collaborator

@burkfers burkfers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:kuzco_nice:

@bstiq bstiq merged commit 793aa0f into Bastardkb:master Sep 9, 2024
1 check passed
@bstiq
Copy link
Member

bstiq commented Sep 9, 2024

Thanks razzeee!

@razzeee
Copy link
Contributor Author

razzeee commented Sep 9, 2024

waaay better, the only thing I'm still not happy with is right switch leg and never having talked about from which side you are looking to figure out where the right is.

@bstiq
Copy link
Member

bstiq commented Sep 9, 2024

This is something that can be figured through schematics or multimeter, so I'm fine with it

@razzeee
Copy link
Contributor Author

razzeee commented Sep 9, 2024

As long as there is no danger in doing that. But I would have liked to be sure, that I've tested the correct right leg when I reached out for help etc

@burkfers
Copy link
Collaborator

burkfers commented Sep 9, 2024

The assembly guides also view the PCBs from the component side at all times. I think "right leg" is precise enough here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants