-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the ZMK firmware descritpion #33
update the ZMK firmware descritpion #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission!
Please also add "nanov" to .wordlist.txt
as a workaround to our spellchecker also picking up URLs. I cannot add this as a suggestion as github doesn't allow change suggestions on unchanged files.
nb: Spelling only; I cannot comment on the contents.
Co-authored-by: burkfers <6268175+burkfers@users.noreply.github.com>
Co-authored-by: burkfers <6268175+burkfers@users.noreply.github.com>
Thanks for catching those spelling mistakes! I've accepted the commits, and added "nanov" to the .wordlist.txt. |
For some reason my other comment doesn't appear. What's the reason you deleted those, is it not up to date anymore? Note that the official ZMK firmware doesn't support the PMW3610 or mouse movement keys, both of which are used in the firmware above. To get a working firmware I leveraged the work of inorichi to get the PMW3610 driver, and the work of petejohanson for the driver to allow pointer movement and scrolling with keys. Official ZMK support for mouse keys is being worked on, and when it's merged I'll switch back to the official ZMK firmware for the builds. |
Great question. I should have put that in my initial message. |
It seems to me you still mention inorichi's driver and Pete's mouse emulation branch, just moved further up (L. 184f). Only the link the the mouse emulation PR is removed. Imho the link to the driver used should stay, both to tell the reader where to go for more information, and to give credit to the authors. Alternatively, you could add these descriptions to a readme in your repo and link it here; That way you have the freedom to change the documentation as you change the code. It's not directly relevant to the setup on the user's side, so not having it directly on the help page is fine. |
Thanks for the feedback! Having the info there instead of the setup guide makes sense to me, but I'll leave the final decision up to you. If you prefer it in both locations, let me know and I'll gladly add another commit to restore the text. |
Thanks for your contribution! 🥳 |
The scope of this PR is to update some of the wording about how to use the firmware. It also includes a short description about the firmware.
I've updated the firmware repo that's linked in this doc and it now builds both qwerty and colemak on the main branch. So it might be a good idea to update the wording to keep from confusing users who click on the link looking for different branches.
Cheers!