Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 45 support #98

Closed
NastyaGrifon opened this issue Nov 4, 2023 · 8 comments
Closed

GNOME 45 support #98

NastyaGrifon opened this issue Nov 4, 2023 · 8 comments
Assignees
Labels

Comments

@NastyaGrifon
Copy link

version 45 is not backwards compatable with plugins made for older versions and requires significant adaptation.

Right now the desk-changer extension cannot be enabled, the settings menu crashes with

SyntaxError: export declarations may only appear at top level of a module

Stack trace:
  @file:///usr/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/prefs.js:4:16
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

Other projects face similar issues: wintile , CoverflowAltTab

Useful resources:
https://gitlab.gnome.org/ewlsh/gjs-guide/-/blob/d4cb8a9fbdf669c791dc24bc1b052e404779157b/docs/extensions/upgrading/gnome-shell-45.md

@BigE
Copy link
Owner

BigE commented Jan 11, 2024

Thanks for the report. I've been able to complete a bit of work recently and everything is in the develop branch that I have so far. I'll continue testing because I'm sure there are things I've missed and errors, but hopefully I can release soon to support 45!

@BigE BigE self-assigned this Jan 11, 2024
@BigE BigE added the bug label Jan 11, 2024
@NastyaGrifon
Copy link
Author

NastyaGrifon commented Jan 11, 2024

At 3db7a1b the extension is mostly working just fine with G45. Tested on Manjaro Gnome

Broken features atm:

  • Show Icon as Preview shows empty image on toolbar
  • Keyboard Shortcut Combination can't be changed and defaults to "Disabled"``

@BigE
Copy link
Owner

BigE commented Jan 13, 2024

Thanks! Oddly enough, the preview bug only happens until the wallpaper is changed, then it shows up and works fine. That's been a source of pain (see #86) and needs a minor rewrite. As for preferences... they're getting a full rewrite to Adw currently, so that should resolve itself 🙃 Thanks again for helping to test things!

@belegdol
Copy link

belegdol commented Mar 4, 2024

It appears adding items to the Profile is not working either. I added a folder using dconf-editor for the time being.

@BigE
Copy link
Owner

BigE commented Mar 12, 2024

It appears adding items to the Profile is not working either. I added a folder using dconf-editor for the time being.

Yes, I've got fixes for all of the bugs listed here, just haven't pushed them yet. I have some downtime this week, so I'll get everything synced up and hopefully make another release soon. Thanks!

@BigE
Copy link
Owner

BigE commented Mar 14, 2024

Okay, preferences are rewritten and mostly working. I could have missed a thing or two, but you should be able to do all of the things from what's pushed into the develop branch. I'll work on getting this cleaned up a bit further and ready for a release... hopefully by the weekend.

@MacBadger
Copy link

cannot wait to get this working again!

@BigE
Copy link
Owner

BigE commented Mar 26, 2024

Updated and released version 36

@BigE BigE closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants