Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Blockchain Code #222

Open
zupzup opened this issue Nov 18, 2024 · 0 comments
Open

Refactor Blockchain Code #222

zupzup opened this issue Nov 18, 2024 · 0 comments
Assignees
Labels
enhancement Enhancement of existing code

Comments

@zupzup
Copy link
Collaborator

zupzup commented Nov 18, 2024

  • Restructure Blockchain code so that it can be used from the service structure
    • Put behind a trait for testability
    • The blockchain code should be self-contained and not rely on fetching bills/keys/anything from the file system - these values should always be passed in from outside.
    • Blockchain code should be passed data, make changes to it, then return the new state, which can then be persisted by the caller
  • Add error-handling and propagate through code-base
  • Make it testable
  • Write tests
  • Document it
@zupzup zupzup added the enhancement Enhancement of existing code label Nov 18, 2024
@zupzup zupzup self-assigned this Nov 18, 2024
@zupzup zupzup moved this to Backlog in Backend (E-Bill) Nov 18, 2024
@mtbitcr mtbitcr added new feature New feature or request and removed new feature New feature or request labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing code
Projects
Status: Todo
Development

No branches or pull requests

2 participants