Merging this project with react-qr-reader #51
Replies: 4 comments 3 replies
-
Hi @JodusNodus, first of all, thanks for your project which has helps us a lot when building web applications that require QR Code Scanning capabilities. We're open to work together in order to merge our changes into the core repository. How do you want us to handle this? Also, since this changes would be in the core repo which is on your user, I would like to ask you obviously if you want, could we create an organization for |
Beta Was this translation helpful? Give feedback.
-
Hey, the main problem is that i no longer use the project in my job or personal projects anymore. So that explain's the lack of motivation to follow up on everything. Which is where you guys could help me out. I question if the project is big enough for a seperate organisation. if alright with you, you can make a pull request. Let me if i should add someone else as a maintainer. Technical question, why did you choose to replace jsqr with zxing, back when i first build it jsqr was quicker and using it in a web worker meant that the main thread could render react without any lag. |
Beta Was this translation helpful? Give feedback.
-
I propose an organization because in our internal roadmap we've the intention to build this library as a universal library (react and react native/expo support), so we think it will scale a little up. About the technical question, we've replaced About using a web worker, that's true, we've the intention to integrate the support again because it would make the library perform better on low range devices. We're looking forward to use this library: https://github.com/alewin/useWorker |
Beta Was this translation helpful? Give feedback.
-
Gotcha, that makes sense. I've setup the org and invited you. The repo has been transfered. Ideally, push your local changes into a new branch on the repo. Then i can complete the setup. I'd like to move the qr processing back into a worker, so ill look into that this week. |
Beta Was this translation helpful? Give feedback.
-
Hey, i've recently been looking into getting react-qr-reader refactored so that it will work with modern stacks. Because as you know i've abandoned it for quite a long time. I've been looking into a refactor with typescript and rollup. I see that you guys have made a lot of progress already. I was wondering if you'd be interested in merging these changes into the official project and maintaining it.
Beta Was this translation helpful? Give feedback.
All reactions