Add CancellationToken overloads. #77
Conversation
There was a problem hiding this comment.
Looks good, but, I don't understand why the Interop class has to be changed to internal. This would cause a breaking change. Yes, I know developers should not reference it, but, for those that are, I never want to introduce a breaking change to add a feature.
src/Blazored.TextEditor/Interop.cs
Outdated
| using System.Threading.Tasks; | ||
|
|
||
| namespace Blazored.TextEditor | ||
| { | ||
| public static class Interop | ||
| internal static class Interop |
There was a problem hiding this comment.
Why is this required?
I just noticed the class only contains internal members so it might as well be internal itself, but you're right it would be a breaking change. I reverted this change. |
|
Can you add examples on the Server project and the Client project that shows how this would be used? |
Fixes #76