Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical timetables don't show trip-specific note symbols #163

Open
brodyFlannigan opened this issue May 11, 2024 · 5 comments
Open

Vertical timetables don't show trip-specific note symbols #163

brodyFlannigan opened this issue May 11, 2024 · 5 comments

Comments

@brodyFlannigan
Copy link

Hi!

In a vertical timetable, if a note is applied to a given trip (using trip_id in timetable_notes_references) but show_on_stoptime is set to 0, the trip note symbol is not placed anywhere on the timetable, but the symbol and note do appear correctly in the footer of the timetable.

The design of the vertical timetable inherently does not fare well with trip specific notes, as there is no "trip header" as is seen in the horizontal timetable in which it would be logical to put notes.

I feel like putting the notes with the first stop times could be a possible solution, but it could cause confusion about the note only applying to that first stop time instead of to the whole trip.

I think the best approach to this would be to add an extra column to the left of the timetable in which symbols could be displayed. This could also be used in multi-route timetables to show the route short name of the trip.

You can see what I mean in this GTFS dataset, which is a modified version of the STO's dataset. You'll notice that a large number of trips have the VOYAGE_ACCESSIBLE note, but that when the timetables are generated, there's no way to identify which trips the note actually applies to...

@brendannee
Copy link
Member

Thanks for mentioning this issue and the example dataset.

The new version 2.6.5 https://github.com/BlinkTagInc/gtfs-to-html/releases/tag/2.6.5 should handle notes for trips by adding a new column to timetables which have any trip notes. Try it out and let me know what you think.

@brodyFlannigan
Copy link
Author

This is great!! I never cease to be blown away by how fast you implement these things.

There are a few little things I feel could be improved though:

  • The column should be able to fit multiple notes for a given trip on a single line, without wrapping.
    image

  • When a timetable is multi-route, the route_short_name of each trip should be shown in the "notes" column (with the corresponding route's route_color and route_text_color)

  • If a timetable isn't multi-route, the note symbols could probably be full-size instead of in superscript.

@brendannee
Copy link
Member

Great ideas.

In the GTFS you shared, is there a timetable page which is multi-route that I could use for testing?

@brodyFlannigan
Copy link
Author

brodyFlannigan commented May 14, 2024

The GTFS I shared previously doesn't have any multi-route tables, but this one does. It'll be STJ.html

Heads up: the timetable is not pretty. It's got way too many timepoints. I'll fix it with timetable_stop_order one day...

@brendannee
Copy link
Member

Thanks for the example GTFS.

Check out the https://github.com/BlinkTagInc/gtfs-to-html/releases/tag/2.6.6 version I just pushed and let me know if it handles all of the items you outlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants