Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling error: sc2api.pb.h not found #319

Open
djurosaur opened this issue Aug 14, 2019 · 4 comments
Open

Compiling error: sc2api.pb.h not found #319

djurosaur opened this issue Aug 14, 2019 · 4 comments

Comments

@djurosaur
Copy link

Followed the steps for compiling this.
https://github.com/Blizzard/s2client-api/blob/master/docs/building.md

Only command i changed is
cmake ../ -G "Visual Studio 15 2017 Win64"

cmake ../ -G "Visual Studio 16 2019"

Could that be issue?

@djurosaur
Copy link
Author

Fix for this is to change file
s2client-api\contrib\protobuf\src\google\protobuf\compiler\java\java_file.cc

L68: bool operator ()(const FieldDescriptor* f1, const FieldDescriptor* f2) const { ... }

There is missing 'const'.

@RobbyG
Copy link

RobbyG commented Aug 16, 2019

I have the same issue and I tried your suggestion but it doesn't seem to change anything; still get the same error

@Weedlepickles
Copy link

Weedlepickles commented Jan 15, 2020

I'm also having this problem. I added the const to the java_file.cc, but it didn't help.
Using this command, cmake ../ -G "Visual Studio 16 2019"
But when I try to compile it in Visual Studio 2019, I get the the compiling error that sc2api.pb.h is missing.

@alkurbatov
Copy link
Contributor

@Weedlepickles you should update the protobuf submodule or use older VS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants