Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element compute_geometry() needs to be private. #41

Open
petrasvestartas opened this issue Nov 12, 2024 · 0 comments
Open

Element compute_geometry() needs to be private. #41

petrasvestartas opened this issue Nov 12, 2024 · 0 comments

Comments

@petrasvestartas
Copy link
Collaborator

petrasvestartas commented Nov 12, 2024

Describe the bug

This method needs to be private:

def compute_geometry(self, include_features=False):

If you run it multiple times, elements are transformed multiple times again and again, changing it location.

I know that my_element.geometry property tries to cache, but still it does not prevent of running this method n-times.

Expected behavior

Two possibilities:
a) transformation is run only once
b) before transformation element is oriented back to its origin frame and then transformed.

Screenshots
Screenshot 2024-11-12 105532
Screenshot 2024-11-12 105554
Screenshot 2024-11-12 105609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant