Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 #22

Open
ryust opened this issue Feb 2, 2018 · 10 comments
Open

1.1.0 #22

ryust opened this issue Feb 2, 2018 · 10 comments
Assignees
Labels

Comments

@ryust
Copy link

ryust commented Feb 2, 2018

Any idea when version 1.1.0 will be released? Or is the library dying off?

@Cliffus
Copy link
Contributor

Cliffus commented Feb 3, 2018

Hi

the library isn't dead yet, but I'l have to admit I didn't put a lot of effort in it the last couple of months.

Which features are you mostly interested in?

Thanks!

@Cliffus Cliffus self-assigned this Feb 3, 2018
@ryust
Copy link
Author

ryust commented Feb 3, 2018

There were some issues I encountered. It would be good if ExpandableTextView extended AppCompatTextView, but I'm able to do without it. Also found out that the ellipse doesn't show if the text was made selectable so dynamically switching it on/off based on collapse state would help. My main problem is the inability to get the text to collapse once it has been expanded... thought that was corrected in 1.1.0 release.

@Cliffus
Copy link
Contributor

Cliffus commented Feb 4, 2018

Thanks for your suggestions!

Can you make for each issue / feature request a ticket? I'll try to make some time to update this library to version 1.1.0.

Can you also provide me an example for the issue where the textview doesn't collapse anymore. Thanks a bunch!

@Cliffus
Copy link
Contributor

Cliffus commented Feb 20, 2018

Hi Ron

Did you already find some time to make some example code so I can reproduce and fix your issue?

Thanks a lot!
Cliff

@ryust
Copy link
Author

ryust commented Feb 20, 2018

No, I just set my app to not collapse the text once it was expanded.

@Cliffus
Copy link
Contributor

Cliffus commented Feb 21, 2018

can you than maybe share some code with me, so I can investigate this issue?

@ryust
Copy link
Author

ryust commented Feb 21, 2018

Sorry, but I don't have a simple test case. The code is part of a larger framework so there's nothing easily shareable. I gave up trying to figure it out.

@Cliffus
Copy link
Contributor

Cliffus commented Feb 22, 2018

Hi Ron

I understand you can't share code of your clients project, but can you at least say in which ViewGroup / layout setup you are using the ExpandableTextView?

I would appreciate it a lot!

@ryust
Copy link
Author

ryust commented Feb 22, 2018

It's immediate parent is a vertical LinearLayout... which is in a TableView... which is in another vertical LinearLayout. Maybe the TableView is a culprit?

@Cliffus
Copy link
Contributor

Cliffus commented Feb 27, 2018

thanks for the information! I'll take a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants