Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_corners_in_ref_space: use affine transformations instead of queries #69

Open
Stannislav opened this issue Aug 30, 2021 · 2 comments
Open

get_corners_in_ref_space: use affine transformations instead of queries #69

Stannislav opened this issue Aug 30, 2021 · 2 comments

Comments

@Stannislav
Copy link
Contributor

At the moment get_corners_in_ref_space sends 4 queries to determine the corner locations in the reference space.

Given we have the machinery to do the transformations locally using affine transformations we should use them in this function to avoid sending unnecesary queries.
@Stannislav Stannislav mentioned this issue Aug 30, 2021
Merged
@jankrepl
Copy link
Contributor

This is a very relevant resource: https://web.archive.org/web/20170420055058/https://efferencecopy.net/allen-brain-fast-image-registration/ together with this https://github.com/charliehass/ecallen/blob/master/ecallen/images.py

@jankrepl
Copy link
Contributor

This issue depends on #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stannislav @jankrepl