Log failed IO that are in a Kamon span #4394
Conversation
|
The non-CE |
| @@ -62,14 +62,15 @@ object KamonMonitoringCats { | |||
| component: String, | |||
| tags: Map[String, Any] = Map.empty, | |||
| takeSamplingDecision: Boolean = true | |||
| )(io: IO[A]): IO[A] = | |||
| )(io: IO[A]): IO[A] = { | |||
| if (enabled) | |||
| buildSpan(name, component, tags).bracketCase(_ => io) { | |||
| case (span, ExitCase.Completed) => finishSpan(span, takeSamplingDecision) | |||
| case (span, ExitCase.Error(cause)) => failSpan(span, cause, takeSamplingDecision) | |||
There was a problem hiding this comment.
The log may be better here ?
There was a problem hiding this comment.
I thought it would still make sense to log the errors even if Kamon is disabled 🤔
There was a problem hiding this comment.
Hum fair point, I think it is ok like this, we can have a refactoring later as it is not only about Kamon anymore.
There is a lot of changes at the moment, it is best to wait a bit before renaming more things
But maybe we should only log only the Rejections ?
Other wise we will be flooded if the database is down for example
There was a problem hiding this comment.
True, it requires to move Rejection to the kernel if I'm not mistaken (which to me would actually make more sense than sourcing-psql anyway). Cf. latest commits
olivergrabinski
dismissed
imsdu’s stale review
The merge-base changed after approval.
olivergrabinski
dismissed
imsdu’s stale review
The merge-base changed after approval.
Closes #4393