Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The game crashes shortly after online login under some virtual environments #50

Open
Bo98 opened this issue Feb 21, 2020 · 0 comments
Open
Labels
crash The game crashes pc-specific PC specific issues
Milestone

Comments

@Bo98
Copy link
Owner

Bo98 commented Feb 21, 2020

The game invokes WMI to retrieve the "chassis type", i.e. the hardware form factor. Due to a combination of insufficient error handling and an incorrect order of operations, the game will crash if WMI returns an error.

The game also fails to properly release all of the objects returned by WMI in the case that more than one is returned - only the last such object is released. This is unlikely to crash, but is nevertheless incorrect code.

This bug is not specific to the remaster. The original game has the same incorrect code.

@Bo98 Bo98 added crash The game crashes pc-specific PC specific issues labels Feb 21, 2020
@Bo98 Bo98 added this to the Next version milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash The game crashes pc-specific PC specific issues
Projects
None yet
Development

No branches or pull requests

1 participant