Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.04.04 5kΩ find also 15kΩ and much more #468

Open
JLA4444 opened this issue May 5, 2024 · 3 comments
Open

2024.04.04 5kΩ find also 15kΩ and much more #468

JLA4444 opened this issue May 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@JLA4444
Copy link

JLA4444 commented May 5, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. When keywords are short like 5kΩ
  2. The suggested lists also shows 15kΩ and so on

Expected behavior
only show 5kΩ resistors

KiCad Version

@chmorgan
Copy link
Collaborator

@JLA4444 can you see if this reproduces with latest master? The keyword match logic was modified slightly and I don't believe its in the 2024.04.04 release.

@Bouni
Copy link
Owner

Bouni commented Jul 3, 2024

Just verified with the current main branch, 5kΩ also matches 15k, 7.5k and so on.

grafik

Maybe we want a checkbox/switch for partial matches!?

@Bouni Bouni added the enhancement New feature or request label Jul 3, 2024
@andy9a9
Copy link
Contributor

andy9a9 commented Nov 26, 2024

This is probably true because of https://github.com/Bouni/kicad-jlcpcb-tools/blob/main/library.py#L136. Try it with longer search than 3. Maybe you should add the checkbox which enable/disable this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants