Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

Incorrect eventLabel with advertising in certain scenarios #16

Open
harniman opened this issue Feb 24, 2017 · 1 comment
Open

Incorrect eventLabel with advertising in certain scenarios #16

harniman opened this issue Feb 24, 2017 · 1 comment

Comments

@harniman
Copy link

I have found two scenarios where the video metadata is not correct when the player is enabled for advertising.

Brightcove player version 5.18.1 (may affect other versions too)
IMA Ad Tag: https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpreonlybumper&cmsid=496&vid=short_onecue&correlator=

Scenario 1
The player is configured with "Preload Video Before User Initiated Playback" set to "No"

Expected behaviour: eventLabel is set to the value of Video ID and Video Name

Actual Behaviour: Null field

Possible cause:
When loadedmetadata is fired for the content, the player is already in the state of ad loading or playing. This suppresses the setting of the media info values due to this code:

loaded = ->
if !isInAdState( player )

Scenario 2
When a player supports playlists and a playlist is played.

Expected Behaviour:
When sending GA events on each item in the playlist eventLabel should be set to the value of Video ID and Video Name

Actual Behaviour:
The values are the same for all items in the play list and non updated

Possible cause:
When loadedmetadata is fired for the content on item change, the player is already in the state of ad loading or playing. This suppresses the updating of the media info values due to this code:

loaded = ->
if !isInAdState( player )

@visualinventor
Copy link

I can confirm our preroll is causing the eventLabel to be empty as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants