fix: file extensions in loadFontsFromDir() are no longer case-sensitive
#707
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yisibl
force-pushed
the
fix-font-ext
branch
6 times, most recently
from
04cdb2e
to
d5173d3
Compare
yisibl
force-pushed
the
fix-font-ext
branch
2 times, most recently
from
e130387
to
7dd4193
Compare
yisibl
changed the title
loadFontsFromDir() are no longer case-sensitive
Brooooooklyn
approved these changes
Aug 21, 2023
yisibl
commented
Aug 22, 2023
| @@ -44,6 +44,9 @@ pub mod GlobalFonts { | |||
| Ok(font.register(font_data.as_ref(), maybe_name_alias)) | |||
| } | |||
|
|
|||
| // TODO: Do file extensions in font_path need to be converted to lowercase? | |||
| // Windows and macOS are case-insensitive, Linux is not. | |||
| // See: https://github.com/Brooooooklyn/canvas/actions/runs/5893418006/job/15985737723 | |||
| #[napi] | |||
| pub fn register_from_path(font_path: String, name_alias: Option<String>) -> Result<bool> { | |||
There was a problem hiding this comment.
@Brooooooklyn 这个方法中扩展名需要转换为小写吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #704