Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to export season to csv #357

Open
wendybo opened this issue Jan 14, 2018 · 4 comments
Open

Unable to export season to csv #357

wendybo opened this issue Jan 14, 2018 · 4 comments

Comments

@wendybo
Copy link

wendybo commented Jan 14, 2018

3 months ago, someone changed the code in seq.py from a set to a dictionary. It appears to break exporting an entire season to a csv file. The error I got was in line 306 'dict' object has no attribute 'add'. Changing that object back to a set seemed to succeed in terms of being able to export the data to a csv file.

Repro steps
1 fresh install nflgame
2 run nflgame.combine(nflgame.games(2010)).csv('season2010.csv')
Expected result export should succeed
Actual result export fails, error occurs

@nehashah264
Copy link

Same error, @BurntSushi can you check and let us know?

@BurntSushi
Copy link
Owner

@nehashah264 No. Please see the README: c9747cc

@wendybo
Copy link
Author

wendybo commented Mar 14, 2018

@nehashah264 I have a fork with the fix, find it here https://github.com/wendybo/nflgame

@rs327008
Copy link

@wendybo thanks that worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants