PP & PET Material #382

c-heat16 · 2023-10-09T22:39:27Z

c-heat16
Oct 9, 2023

Whenever I try to save a project with a material named 'PP' I get the following error:

Traceback (most recent call last):
  File "/Users/czh/projects/cript_gui_upload_tool/scratch.py", line 120, in <module>
    api.save(project)
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 704, in save
    raise exc from exc
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 698, in save
    self._internal_save(project)
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 773, in _internal_save
    raise exc
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 764, in _internal_save
    returned_save_values = _fix_node_save(self, node, response, save_values)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/utils/save_helper.py", line 104, in _fix_node_save
    save_values += api._internal_save(duplicate_node, save_values)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 773, in _internal_save
    raise exc
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 764, in _internal_save
    returned_save_values = _fix_node_save(self, node, response, save_values)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/utils/save_helper.py", line 77, in _fix_node_save
    returned_save_values = api._internal_save(missing_node, save_values)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 796, in _internal_save
    raise CRIPTAPISaveError(api_host_domain=self._host, http_code=response["code"], api_response=response["error"], patch_request=patch_request, pre_saved_nodes=save_values.saved_uuid, json_data=json_data)  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cript.api.exceptions.CRIPTAPISaveError: API responded to POST with 'http:400 The browser (or proxy) sent a request that this server could not understand.' data: {"node": ["Material"], "uid": "_:68d927bc-93bf-42d6-9c0c-e90fdd67b86c", "uuid": "68d927bc-93bf-42d6-9c0c-e90fdd67b86c", "name": "PP", "names": ["PP"]}

If I try to retrieve this material via

pp_paginator = api.search(
    node_type=cript.Material,
    search_mode=cript.SearchModes.EXACT_NAME,
    value_to_search='PP'
)
pp = pp_paginator.current_page_results[0]
pp = cript.load_nodes_from_json(json.dumps(pp))

I get the following error:

Traceback (most recent call last):
  File "/Users/czh/projects/cript_gui_upload_tool/scratch.py", line 58, in <module>
    pp_paginator = api.search(
                   ^^^^^^^^^^^
  File "<@beartype(cript.api.api.API.search) at 0x10e555e40>", line 56, in search
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 1079, in search
    return Paginator(http_headers=self._http_headers, api_endpoint=api_endpoint, query=value_to_search, current_page_number=page_number)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<@beartype(cript.api.paginator.Paginator.__init__) at 0x10e3b4720>", line 92, in __init__
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/paginator.py", line 95, in __init__
    self.fetch_page_from_api()
  File "<@beartype(cript.api.paginator.Paginator.fetch_page_from_api) at 0x10e3b6a20>", line 14, in fetch_page_from_api
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/paginator.py", line 230, in fetch_page_from_api
    raise APIError(api_error=str(response), http_method="GET", api_url=temp_api_endpoint)
cript.api.exceptions.APIError: CRIPT Python SDK sent HTTP `GET` request to URL: `https://api.criptapp.org/api/v1/search/exact/material/?q=PP&page=0` and API responded with <Response [400]>

I can create a material named 'PET' (pet = cript.Material(name='PET', identifier=[{'names': ['PET']}])) and save it with a project, but when I try to retrieve it via

pet_paginator = api.search(
    node_type=cript.Material,
    search_mode=cript.SearchModes.EXACT_NAME,
    value_to_search='PET'
)
pet = pet_paginator.current_page_results[0]
pet = cript.load_nodes_from_json(json.dumps(pet))

I get the following error:

Traceback (most recent call last):
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/nodes/util/__init__.py", line 309, in __call__
    json_node = pyclass._from_json(node_dict)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/nodes/subobjects/ingredient.py", line 118, in _from_json
    if isinstance(json_dict["material"], list):
                  ~~~~~~~~~^^^^^^^^^^^^
KeyError: 'material'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/czh/projects/cript_gui_upload_tool/scratch.py", line 73, in <module>
    pet = cript.load_nodes_from_json(json.dumps(pet))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/nodes/util/__init__.py", line 450, in load_nodes_from_json
    json_nodes = json.loads(nodes_json, object_hook=node_json_hook)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/__init__.py", line 359, in loads
    return cls(**kw).decode(s)
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/nodes/util/__init__.py", line 313, in __call__
    raise CRIPTJsonDeserializationError(key, str(node_type_str)) from exc
cript.nodes.exceptions.CRIPTJsonDeserializationError: JSON deserialization failed for node type Ingredient with JSON str: Ingredient

The retrieval works for materials with different names, however. I have deleted all of my projects in 'My CRIPT' - which says it deletes child nodes - but the issue persists. Can you please advise how I can use these materials?

(updated to try and improve formatting)

c-heat16 · 2023-10-09T23:08:14Z

c-heat16
Oct 9, 2023
Author

In working to document a different issue wrt displaying products, I created a material 'mat1' in a project I saved and later deleted via the website. However, I can no longer retrieve 'mat1' via search. The code below was originally run to create a project which was saved and deleted. Upon running the code again, trying to fetch 'mat1' I get an error message. As we can see in the error message, it looks like a matching node was found, but an error arise in dumping/parsing the json.

import os
import json
import cript


def make_fetch_node(
        api, node_name, node_type=cript.Project,
        search_mode=cript.SearchModes.EXACT_NAME,
        **kwargs
):
    res_paginator = api.search(
        node_type=node_type,
        search_mode=search_mode,
        value_to_search=node_name
    )

    try:
        print('* selecting first result on first page *')
        to_return = res_paginator.current_page_results[0]
        print('* dumping json and loading *')
        to_return = cript.load_nodes_from_json(json.dumps(to_return))
        print('* NODE RETRIEVED *')
        return to_return

    except Exception:
        print('* CREATING NODE *')
        kwargs['name'] = node_name
        if node_type != cript.Project and node_type != cript.Collection:
            kwargs['identifier'] = []
        return node_type(**kwargs)

api_token = os.environ.get('CRIPT_API_TOKEN')
storage_token = os.environ.get('CRIPT_STORAGE_TOKEN')

api = cript.API(
    host='https://api.criptapp.org',
    api_token=api_token, storage_token=storage_token
)
api.connect()

project = cript.Project(name='My Toy Project')
collection = cript.Collection(name='My Toy Collection')
project.collection += [collection]

expt1 = cript.Experiment(name='Toy experiment 1')
collection.experiment += [expt1]

mat1 = make_fetch_node(
    api, node_name='mat1', node_type=cript.Material
)

inventory = cript.Inventory(
    name='Toy Inventory',
    material=[mat1]
)
collection.inventory += [inventory]

process1 = cript.Process(name='Pyrolysis Expt 1', type='multistep', description='')
expt1.process += [process1]

quantity1 = cript.Quantity(key='mass', value=5e-5, unit='kg')
initiator1 = cript.Ingredient(keyword=['initiator'], material=mat1, quantity=[quantity1])

process1.ingredient += [initiator1]

print('Validating project...')
project.validate()

print('Saving...')
api.save(project)

api.disconnect()

Output after deleting project and running again:

(cript_venv) czh@Connors-MacBook-Pro cript_gui_upload_tool % python3 scratch.py
INFO: Validating Project graph...
INFO: Validating Collection graph...
INFO: Validating Project graph...
INFO: Validating Experiment graph...
INFO: Validating Collection graph...
* selecting first result on first page *
* dumping json and loading *
* CREATING NODE *
INFO: Validating Collection graph...
INFO: Validating Process graph...
INFO: Validating Experiment graph...
INFO: Validating Quantity graph...
INFO: Validating Ingredient graph...
INFO: Validating Process graph...
Validating project...
INFO: Validating Project graph...
Saving...
INFO: Validating Project graph...
INFO: Validating Material graph...
INFO: Validating Material graph...
Traceback (most recent call last):
  File "/Users/czh/projects/cript_gui_upload_tool/scratch.py", line 74, in <module>
    api.save(project)
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 704, in save
    raise exc from exc
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 698, in save
    self._internal_save(project)
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 773, in _internal_save
    raise exc
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 764, in _internal_save
    returned_save_values = _fix_node_save(self, node, response, save_values)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/utils/save_helper.py", line 77, in _fix_node_save
    returned_save_values = api._internal_save(missing_node, save_values)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/czh/projects/cript_gui_upload_tool/cript_venv/lib/python3.11/site-packages/cript/api/api.py", line 771, in _internal_save
    raise CRIPTDuplicateNameError(response, json_data, exc) from exc
cript.api.exceptions.CRIPTDuplicateNameError: The name 'mat1' for your Material node is already present in CRIPT. Either choose a new name!

We see * dumping json and loading * was printed but * NODE RETRIEVED * was not.

Any guidance would be much appreciated.

0 replies

nh916 · 2023-10-10T18:48:57Z

nh916
Oct 10, 2023

Hi @c-heat16 ,

Would you be available to have a meeting to go over the issues together?

I originally wrote out a longer message that I was going to write here, but I think that it'll probably cause more confusion than help because it could be one of several things, and I'm thinking that if we go through it together it'll probably be easier and faster. Would you be up for that?

2 replies

c-heat16 Oct 10, 2023
Author

Hi @nh916 , that would be great. I believe we have emailed before - let me know when you are free. I'm mostly free W/Th/F this week except Thursday afternoon. Whatever works for you

nh916 Oct 10, 2023

Hi @c-heat16 sent you an email!

c-heat16 · 2023-10-15T14:13:55Z

c-heat16
Oct 15, 2023
Author

Is there a minimum character limit for material names? I had trouble retrieving a 'PP' material, and am having the same issue with 'He', 'N2', and 'Ar' - carrier gasses. However, simply adding an underscore to the material name alleviates the issue.

script to reproduce:

import os
import json
import cript
import argparse


def fancy_print(print_str, decorator='*'):
    print('{}\n{}\n{}'.format(
        decorator * len(print_str), print_str, decorator * len(print_str)
    ))


def make_fetch_node(
        api, node_name, node_type=cript.Project, search_mode=cript.SearchModes.EXACT_NAME,
        verbosity=1,
        **kwargs
):
    if verbosity >= 1:
        fancy_print('* searching for {} *'.format(node_name))
    res_paginator = api.search(
        node_type=node_type,
        search_mode=search_mode,
        value_to_search=node_name
    )

    try:
        # print('* selecting first result on first page *')
        to_return = res_paginator.current_page_results[0]
        if verbosity >= 1:
            fancy_print('* loading existing {} from json *'.format(node_name))

        to_return = cript.load_nodes_from_json(json.dumps(to_return))
        if verbosity >= 1:
            fancy_print('* existing {} node retrieved *'.format(node_name))
        return to_return

    except Exception:
        if verbosity >= 1:
            fancy_print('* creating {} node *'.format(node_name))

        kwargs['name'] = node_name
        if node_type != cript.Project and node_type != cript.Collection and node_type != cript.Inventory:
            identifier = kwargs.get('identifier', [])
            identifier.append({'names': [node_name]})
            kwargs['identifier'] = identifier
        return node_type(**kwargs)


if __name__ == '__main__':
    parser = argparse.ArgumentParser()

    parser.add_argument('--project_name', default='Toraman Group Test')
    parser.add_argument('--collection_name', default='PP/PET Pyrolysis Dataset')

    args = parser.parse_args()

    api_token = os.environ.get('CRIPT_API_TOKEN')
    storage_token = os.environ.get('CRIPT_STORAGE_TOKEN')

    api = cript.API(
        host='https://api.criptapp.org',
        api_token=api_token, storage_token=storage_token
    )
    api.connect()

    he = make_fetch_node(api, 'He_', node_type=cript.Material)  # works
    he = make_fetch_node(api, 'He', node_type=cript.Material)   # fails

Error on second call:

Traceback (most recent call last):
  File "/home/czh/nvme1/cript_sandbox/scratch.py", line 69, in <module>
    he = make_fetch_node(api, 'He', node_type=cript.Material)
  File "/home/czh/nvme1/cript_sandbox/scratch.py", line 22, in make_fetch_node
    res_paginator = api.search(
  File "<@beartype(cript.api.api.API.search) at 0x7f71da5bbf40>", line 56, in search
  File "/home/czh/nvme1/cript_sandbox/cript_venv/lib/python3.10/site-packages/cript/api/api.py", line 1079, in search
    return Paginator(http_headers=self._http_headers, api_endpoint=api_endpoint, query=value_to_search, current_page_number=page_number)
  File "<@beartype(cript.api.paginator.Paginator.__init__) at 0x7f71da6253f0>", line 92, in __init__
  File "/home/czh/nvme1/cript_sandbox/cript_venv/lib/python3.10/site-packages/cript/api/paginator.py", line 95, in __init__
    self.fetch_page_from_api()
  File "<@beartype(cript.api.paginator.Paginator.fetch_page_from_api) at 0x7f71da6271c0>", line 14, in fetch_page_from_api
  File "/home/czh/nvme1/cript_sandbox/cript_venv/lib/python3.10/site-packages/cript/api/paginator.py", line 230, in fetch_page_from_api
    raise APIError(api_error=str(response), http_method="GET", api_url=temp_api_endpoint)
cript.api.exceptions.APIError: CRIPT Python SDK sent HTTP `GET` request to URL: `https://api.criptapp.org/api/v1/search/exact/material/?q=He&page=0` and API responded with <Response [400]>

0 replies

nh916 · 2023-10-16T19:34:25Z

nh916
Oct 16, 2023

hi @c-heat16 thank you so much for letting me know. I think this might be an API error. I think the issue is that the API has a DB schema that has a minimum length of 2 for the name.

DB Schema

      "NameField": {
        "$id": "NameField",
        "maxLength": 2048,
        "minLength": 2,
        "pattern": "^[^^<>|$]+$",
        "type": "string"
      }

I reported this to the API and I'll report back when I have an answer.

heads up: I am going through a bunch of user issues right now, so if you don't hear back from me in a week or 2 feel free to ping me again to be sure it doesn't get missed. Also, feel free to break up the issues to multiple discussions or issues to be sure it doesn't get missed

0 replies

nh916 · 2023-10-17T19:12:41Z

nh916
Oct 17, 2023

@c-heat16 I talked to the backend software engineer and he said that all material names must be at least 3 characters long and that is something that we will not be changing for now

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PP & PET Material #382

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 5 comments 2 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

PP & PET Material #382

c-heat16 Oct 9, 2023

Replies: 5 comments · 2 replies

c-heat16 Oct 9, 2023 Author

nh916 Oct 10, 2023

c-heat16 Oct 10, 2023 Author

nh916 Oct 10, 2023

c-heat16 Oct 15, 2023 Author

nh916 Oct 16, 2023

nh916 Oct 17, 2023

c-heat16
Oct 9, 2023

Replies: 5 comments 2 replies

c-heat16
Oct 9, 2023
Author

nh916
Oct 10, 2023

c-heat16 Oct 10, 2023
Author

c-heat16
Oct 15, 2023
Author

nh916
Oct 16, 2023

nh916
Oct 17, 2023