Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still required to register for new account despite ACCOUNT_REGISTRATION=false and ALLOW_UNAUTHENTICATED=true #201

Closed
tejashah88 opened this issue Dec 26, 2024 · 2 comments · Fixed by #203

Comments

@tejashah88
Copy link
Contributor

I have the following docker-compose.yml file to launch this app locally on my PC for personal use.

services:
  convertx:
    image: ghcr.io/c4illin/convertx
    container_name: convertx
    restart: unless-stopped
    ports:
      - "3000:3000"
    environment:
      - ACCOUNT_REGISTRATION=false
      - ALLOW_UNAUTHENTICATED=true
      - AUTO_DELETE_EVERY_N_HOURS=0
      - HTTP_ALLOWED=true
    volumes:
      - ./data:/app/data

I tried running this with Docker Compose but when opening up the webpage on localhost:3000, it leads me to a setup page, where I'm required to register for an account despite specifying ACCOUNT_REGISTRATION=false and ALLOW_UNAUTHENTICATED=true and HTTP_ALLOWED=true. This was tested on an Incognito Window using the Brave Browser (Chrome-based) on a Windows 10 Pro Laptop.

image

Peering through the source code, I think I found a potential culprit. The FIRST_RUN variable is set when no users exist, but the ALLOW_UNAUTHENTICATED flag is not checked in conjunction, which causes the routing to send the user to /setup until a user is finally found in the database.

I can imagine a temporary workaround is to put a dummy user into the database when ALLOW_UNAUTHENTICATED is set to true, but I'd like to know what you think.

@tejashah88
Copy link
Contributor Author

One obvious thing to note is that after creating the user, shutting down the container and restarting it back up, it won't prompt me for the login details since there's at least one user in the database.

@armond-avanes
Copy link

I'm facing the exact same issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants