Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv3d utility #36

Open
water-e opened this issue Jul 21, 2023 · 5 comments
Open

uv3d utility #36

water-e opened this issue Jul 21, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@water-e
Copy link
Collaborator

water-e commented Jul 21, 2023

Design is in BayDeltaSCHISM/bdschism_design.py.txt, including an interface that includes the required options. Need:
implementation, in stages:

  1. First stage should work on basic case where interpolate_variables executable is on path and no special links, but would include use of param.nml for inference. Other stuff should raise NotImplementedError. First stage includes create_arg_parser and should be formatted using the 'black' formatter which you can install in python or through VS Code.
  2. Second stage should be a complete installation
  3. The utility 'uv3d' (all lower case) should be listed in setup.py of bdschism so that the python file automatically turns into a native utility
  4. Document in topical guide, with references in vignette. This can mostly be done automatically with sphinx_argparse.
  5. Take care of cloud issues, especially batch, when it isn't clear that interpolate variables is on path. Perhaps this script would have to be wrapped? Check in with Nicky and Shey on this.
@HansKimDWR
Copy link
Contributor

@water-e I have two questions:

  1. What do we do if interpolate_variables.in is not given? Should we create interpolate_variables.in based on the contents of param.nml?
  2. Could we assume Linux environment? That is, could we use "ln -sf" whenever symbolic links are created?

@water-e
Copy link
Collaborator Author

water-e commented Jul 21, 2023 via email

@HansKimDWR
Copy link
Contributor

@water-e I have re-read the design document, but something is still not clear to me: interpolate_variables8 is a binary that is hard-wired to read interpolate_variables.in. Without this input file, how do we give parameter values to the binary? Could you give more guidance please?

@HansKimDWR
Copy link
Contributor

@water-e @dwr-psandhu My latest commit to uv3D (https://github.com/CADWRDeltaModeling/BayDeltaSCHISM/blob/master/bdschism/bdschism/uv3d.py) contains all necessary implementations except for running interpolate_variables8 executable.
The issue is that the series of subprocess.run() commands at the end of the main function does not run correctly. It seems interpolate_variables8 is run even before the command "ulimit -s unlimited" is registered, and segmentation fault error is encountered.
Is there a better way of running series of shell commands?

@water-e
Copy link
Collaborator Author

water-e commented Jul 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants